fix(avatar): Use Nextcloud HTTP client for favicons #10363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable4.2 |
st3iny
approved these changes
Nov 18, 2024
|
/backport to stable4.1 |
|
/backport to stable4.0 |
|
PHP cs fixer failures are legit. |
|
/backport to stable3.7 |
kesselb
approved these changes
Nov 18, 2024
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/avatar/favicon-http-client
branch
from
31e89e8
to
eee2d6a
Compare
This was referenced Nov 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6167
Fetching of an avatar was already done through the Nextcloud HTTP client, but the discovery was not.