Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary actions design issues #6201

Closed
ChristophWurst opened this issue Apr 7, 2022 · 12 comments
Closed

Primary actions design issues #6201

ChristophWurst opened this issue Apr 7, 2022 · 12 comments
Labels
1. to develop bug design papercut Annoying recurring issue with possibly simple fix.
Milestone

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 7, 2022

Steps to reproduce

  1. Open the actions menu of a message/thread

Expected behavior

The three primary actions have the same width.

Actual behavior

Bildschirmfoto vom 2022-04-07 20-50-29
Bildschirmfoto vom 2022-04-07 20-50-21
Bildschirmfoto vom 2022-04-07 20-50-18

Mail app version

1.x

Mailserver or service

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database

No response

Additional info

Ref #6098

@ChristophWurst ChristophWurst added bug 1. to develop design papercut Annoying recurring issue with possibly simple fix. labels Apr 7, 2022
@ChristophWurst ChristophWurst added this to the v1.12.0 milestone Apr 7, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team Apr 7, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Apr 19, 2022
@JuliaKirschenheuter
Copy link
Contributor

@ChristophWurst i have discussed this issue with @jancborchardt, as i've implemented it. To have a same width for primary actions i have to do a some fix width for them. And it is not always helpful for different languages (because the title will be either cut or have a second line).

@jancborchardt told that is is ok, how it is looks like. Is there some new info?
@ChristophWurst, @jancborchardt please reply

@JuliaKirschenheuter JuliaKirschenheuter removed their assignment Apr 26, 2022
@ChristophWurst
Copy link
Member Author

If this is intended then I'm okay with it. I'm not a designer. It's just that something makes this UI look unpolished. Maybe @nimishavijay can share a secondary opinion? :)

@ChristophWurst ChristophWurst removed this from the v1.12.0 milestone Apr 29, 2022
@nimishavijay
Copy link
Member

Yes, we had discussed this. We thought we could calculate the width of the button with the longest text, and use that length for all the buttons, but turns out it's too difficult, so we decided to keep it this way :)

If it is possible to adjust the width of the buttons considering all languages and lengths of text without any fancy javascript stuff then I think we should totally do it like that :)

@ChristophWurst
Copy link
Member Author

Bildschirmfoto vom 2022-05-16 08-18-39

I can't help it but something feels off with this new menu. Do we need larger icons? Some breathing space somewhere? A rounded background like in #6200 (comment)?

@JuliaKirschenheuter
Copy link
Contributor

A rounded background like in #6200 (comment)?

I'm not sure, that rounded background would help (it looks nice, but we should rethink a way of positioning). My suggestion: leave only icons, without text, text put into <aria-label>. And change icons depends on the state (read - unread)

@jancborchardt
Copy link
Member

It's also possible that now that actions can't have the whole width, we need to make sure translations cut their wording down too, like we did from "Mark as read" to "Read" etc.

Going icon-only is not really user-friendly, especially the "Important" icon is not common. Before we end up going that route, I'd say going back to putting the top 3 normally in the list is better. (But not before we tried the text cutting in translations.)

@JuliaKirschenheuter
Copy link
Contributor

It's also possible that now that actions can't have the whole width, we need to make sure translations cut their wording down too, like we did from "Mark as read" to "Read" etc.

Hm, how could we influence translations in this special case?

Going icon-only is not really user-friendly, especially the "Important" icon is not common.

Ok

@ChristophWurst
Copy link
Member Author

We have to adjust the English text and hope that the translations are also short.

We will likely run into strangely translated strings for some languages, though. Like the English Read will likely be translated to Lesen or Gelesen for German.

https://cdn.vox-cdn.com/uploads/chorus_asset/file/20032761/Hey_image_2.png they do something similar and it looks "designed".

@ChristophWurst
Copy link
Member Author

ChristophWurst commented May 17, 2022

I'm experiment with more modern, consistent icon design. I think this looks a bit more "designed" than what we currently have:

Before After After with rounded corners
Bildschirmfoto vom 2022-05-17 15-07-09 Bildschirmfoto vom 2022-05-17 15-05-29 Bildschirmfoto vom 2022-05-17 15-16-28

Please ignore the other missing icons. This problem is tracked in #6478.

@ChristophWurst ChristophWurst changed the title Message primary actions should all have the same width Primary actions design improvements May 17, 2022
@jancborchardt
Copy link
Member

@ChristophWurst nice, good stuff on using Material Design icons. Rounded corners also look good, but should then be done consistently in the menu entries below, as well as on the menu itself → @nimishavijay you mocked that up somewhere but I can’t find it, could you link it? :)

@ChristophWurst
Copy link
Member Author

#6200 (comment).

I know those things are not tightly related, hence the two screenshots. But I'd push to get there soon.

@ChristophWurst ChristophWurst changed the title Primary actions design improvements Primary actions design issues May 17, 2022
@ChristophWurst ChristophWurst added this to the v1.14.0 milestone Aug 24, 2022
@ChristophWurst
Copy link
Member Author

Things are round now and look a lot better.

Repository owner moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug design papercut Annoying recurring issue with possibly simple fix.
Projects
Development

No branches or pull requests

4 participants