Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent background corner radius in left/middle rows #6200

Closed
2 tasks
ChristophWurst opened this issue Apr 7, 2022 · 7 comments
Closed
2 tasks

Inconsistent background corner radius in left/middle rows #6200

ChristophWurst opened this issue Apr 7, 2022 · 7 comments
Assignees
Labels
1. to develop blocked bug design papercut Annoying recurring issue with possibly simple fix.

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 7, 2022

Steps to reproduce

  1. Nothing specific to prepare but at least one account and some messages

Expected behavior

Consistent design

Actual behavior

Bildschirmfoto vom 2022-04-07 20-45-57
Bildschirmfoto vom 2022-04-07 20-46-09
Bildschirmfoto vom 2022-04-07 20-49-24
Bildschirmfoto vom 2022-04-07 20-49-17

Mail app version

1.x

Mailserver or service

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database

No response

Additional info

@ChristophWurst ChristophWurst added bug 1. to develop design papercut Annoying recurring issue with possibly simple fix. labels Apr 7, 2022
@ChristophWurst ChristophWurst added this to the v1.12.0 milestone Apr 7, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team Apr 7, 2022
@ChristophWurst ChristophWurst changed the title Inconsistent border radios in left/middle rows Inconsistent background corner radius in left/middle rows Apr 7, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Apr 25, 2022
@JuliaKirschenheuter
Copy link
Contributor

@nimishavijay please give a feedback, which design should we use?

@nimishavijay
Copy link
Member

nimishavijay commented Apr 25, 2022

Good point! We should change the component itself so that it is reflected across all apps :)

My suggestion:

  • border-radius: 6px for each item in the action menu
  • border-radius: 8px for the action menu itself
  • padding: 4px for the action menu

It would look like this
image
What do you think? cc @jancborchardt @marcoambrosini

@jancborchardt
Copy link
Member

Yeeeeah that looks sick @nimishavijay! :)

Regarding the AppNavigation, there’s nextcloud-libraries/nextcloud-vue#2460 which @quentinguidee / @marcoambrosini wanted to look at, so we should make sure it’s the same. :)

@JuliaKirschenheuter JuliaKirschenheuter removed their assignment Apr 26, 2022
@ChristophWurst ChristophWurst removed this from the v1.12.0 milestone Apr 29, 2022
@ChristophWurst
Copy link
Member Author

This is too big of a change to be delivered with v1.12

@jancborchardt
Copy link
Member

This seems to be fixed with the 2 Vue component pull requests, is it not?

@marcoambrosini
Copy link
Member

Yep this is fixed in master, needs release

@GretaD
Copy link
Contributor

GretaD commented Oct 17, 2022

all background border corner radius are consistent everywhere in mail now

@GretaD GretaD closed this as completed Oct 17, 2022
Repository owner moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop blocked bug design papercut Annoying recurring issue with possibly simple fix.
Projects
Development

No branches or pull requests

6 participants