Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26] allow printing log messages during occ #998

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Sep 19, 2023

blizzz
blizzz previously requested changes Oct 10, 2023
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BeforeMessageLoggedEvent was introduced in 27.0.1 only

(that's what the require is about, just blocking to avoid accidental merge)

@blizzz
Copy link
Member

blizzz commented Oct 11, 2023

CI is failing

ERROR: InvalidArgument - lib/Listener/LogListener.php:58:62 - Argument 3 of OCA\LogReader\Log\Console::log expects array<array-key, mixed>, but string provided (see https://psalm.dev/004)
			$this->console->log($event->getLevel(), $event->getApp(), $event->getMessage());

I would have expected this on the master and 27 PRs as well, but there it didn't appear.

@susnux
Copy link
Contributor

susnux commented Nov 9, 2023

@blizzz on master & stable27 the typing of BeforeMessageLoggedEvent is correct, but for stable26 the typing of getMessage() is string instead of array.

@susnux
Copy link
Contributor

susnux commented Nov 9, 2023

@blizz

This comment was marked as resolved.

@susnux

This comment was marked as off-topic.

@blizzz blizzz merged commit 20d69a6 into stable26 Nov 15, 2023
21 checks passed
@blizzz blizzz deleted the occ-log-printer-26 branch November 15, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants