Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Chat app sidebar / user list more with Contacts menu #21

Open
jancborchardt opened this issue May 30, 2017 · 9 comments
Open

Merge Chat app sidebar / user list more with Contacts menu #21

jancborchardt opened this issue May 30, 2017 · 9 comments

Comments

@jancborchardt
Copy link
Member

jancborchardt commented May 30, 2017

Now that the Chat function is properly integrated in the Contacts menu with #13, it would be cool to see how we can combine further.

We have the conversation windows on the bottom for each person or group, which are good.
Then there’s a big user list on the right though, either shown or not shown. This is exactly why we developed the Contacts menu/popover to not be so present and be easier to include in the apps layouts, especially with some apps like Files and Tasks using a right sidebar already. :)

Some things are missing from the Contacts menu though, for example:

Could we move these things from the user list to the Contacts menu in an effort to move towards one unified solution? :) What do you think @sualko @ChristophWurst @karlitschek?

@sualko
Copy link
Member

sualko commented May 30, 2017

As mentioned earlier it would be cool to unify the contact list, but not every xmpp contact is in the users address book. We would need a way to manipulate this list on the client side (adding, removing, updating xmpp contacts).

  • Online status is already visualized by a colored bubble in the top right corner of the chat icon
  • Last message: I think this would be possible
  • Notification? What do you mean? Is there a nc js api for this? Jsxc already displays html5 notifications.
  • Ordering: How can I manipulate the order on client side, because the hole xmpp stuff is handled client-side?

@jancborchardt
Copy link
Member Author

Online status is already visualized by a colored bubble in the top right corner of the chat icon

Yup, and that should ideally also go into the Contacts menu. :) As was commented at nextcloud/server#207 (comment)

Notification? What do you mean? Is there a nc js api for this? Jsxc already displays html5 notifications.

I mean simply changing the Contacts menu icon to full opacity and maybe adding a red bubble to it when there is a new message.

Ordering: How can I manipulate the order on client side, because the hole xmpp stuff is handled client-side?

@ChristophWurst @georgehrke can you advise here? :)

@sualko
Copy link
Member

sualko commented May 30, 2017

Yup, and that should ideally also go into the Contacts menu.

I meant it's already there (maybe it's to small 😋):
screenshot from 2017-05-30 17-17-49

maybe adding a red bubble to it when there is a new message.

If there is an api for that, I am happy to use it. Otherwise I could create a red bubble by myself, but I think it should be all little more "official".

@jancborchardt
Copy link
Member Author

@sualko alright! I meant having the bubble on the avatar, as it currently is in the sidebar of the Chat app. :) And another point of enhancement (added it above too):

  • if the chat app is installed, clicking anywhere on the avatar or name should also launch a chat. :)

@sualko
Copy link
Member

sualko commented Jun 2, 2017

I meant having the bubble on the avatar

We have to consider, that there could be cases where people have multiple accounts, e.g. work and privat, linked in a contact. One solution would be to aggregate those presences and show only the highest available on the avatar. On hover we could show more details. We have a similar issue if we like to launch a chat by clicking on an avatar if it belongs to an address book entry and not to an nc user. Any ideas how to solve this?

@jancborchardt
Copy link
Member Author

@sualko good point. We could presume that the default is one chat account. If there are multiple ones, clicking on the avatar/name could also open the 3-dot menu with the different chat accounts in there and user handles showing next to them as we do when people have several email addresses.

And yes, the highest »available« status should be used for the avatar. Meaning if you are online on any of your accounts, you will show as online.

sualko added a commit that referenced this issue Jun 27, 2017
- click on avatar opens chat window
- last message is shown below the name
- aggregated avatar presence icon

ref #21
@sualko
Copy link
Member

sualko commented Jun 27, 2017

I added your first 3 points to the contact menu:

  • Last message written with that person
  • Online status directly on the avatar
  • Clicking the avatar should launch a chat

screenshot from 2017-06-27 13-28-24

@jancborchardt
Copy link
Member Author

Awesome! Check it out @karlitschek @ChristophWurst :)

@karlitschek
Copy link
Member

wow. this is suuuper cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants