Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: quote nextcloud.objectStore.s3.legacyAuth value when rendering as env var #638

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jessebot
Copy link
Collaborator

Description of the change

This quotes the nextcloud.objectStore.s3.legacyAuth value when rendering it as an env var in _helpers.tpl. I think that's why it wasn't working before.

Benefits

Without this fix, setting the value to true doesn't work.

Possible drawbacks

We could also just have it be this to be more explicit, since the with will ignore a value of false anyway:

{{- with .Values.nextcloud.objectStore.s3.legacyAuth }}
- name: OBJECTSTORE_S3_LEGACYAUTH
  value: "true"
{{- end }}

Either should solve the issue 🤷

Applicable issues

Checklist

@jessebot jessebot added the S3 Anything to do with S3 object storage label Sep 25, 2024
@jessebot jessebot self-assigned this Sep 25, 2024
@jessebot jessebot added the 3. to review Waiting for reviews label Sep 25, 2024
@jessebot
Copy link
Collaborator Author

Thanks for the super fast review! 🙏

@jessebot jessebot merged commit feaf104 into nextcloud:main Sep 25, 2024
9 checks passed
@jessebot jessebot deleted the fix-s3-legacy-auth-quotation branch September 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews S3 Anything to do with S3 object storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting nextcloud.objectStore.s3.legacyAuth is not being set as string env var
2 participants