add default of "" for externalDatabase.host; update README to be a little more clear #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e more clear Signed-off-by: jessebot <[email protected]>
provokateurin
approved these changes
Sep 24, 2024
jessebot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a default for
externalDatabase.hostto be""so it's clear the type taken, and also reminds people that they need to quote when using a:in a value in yaml. Also adds a bit more of a comment for that value and updates the README to reflect both changes.Benefits
Just resolves tiny bit of possible confusion around how to specify a database port.
Possible drawbacks
none that I can think of
Applicable issues
Checklist
Chart.yamlaccording to semver.