Add: Redis persistent volumes settings to values #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FreekO <[email protected]>
Signed-off-by: FreekO <[email protected]>
Signed-off-by: JesseBot <[email protected]>
jessebot
reviewed
May 5, 2024
jessebot
reviewed
May 5, 2024
jessebot
reviewed
May 5, 2024
Signed-off-by: Jesse Hitch <[email protected]>
jessebot
approved these changes
Jul 22, 2024
|
waiting for the tests to finish and then I'll get this merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Added Redis persistent volume settings to values and the readme. This is only to make users aware of how to change these settings, the PR itself doesn't contain any changes to the functioning of the chart.
Benefits
It will make people aware of how to change the persistent volume settings for Redis.
Possible drawbacks
Too many settings in values might "clutter" the values file and readme.
Applicable issues
Additional information
not applicable
Checklist
Chart.yamlaccording to semver.