Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Fix labeled version autoExpire #3420

Closed
wants to merge 1 commit into from
Closed

[stable28] Fix labeled version autoExpire #3420

wants to merge 1 commit into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 13, 2024

Backport of PR #3393

@XueSheng-GIT @artonge @backportbot
Fix labeled version expiry
f7ef94b 
Co-authored-by: Louis <[email protected]>
Signed-off-by: XueSheng-GIT <[email protected]>
@backportbot backportbot bot requested a review from artonge November 13, 2024 12:50
@backportbot backportbot bot added bug 3. to review Items that need to be reviewed php Items related to PHP updates and code issues feature: versions Items related to file versioning labels Nov 13, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.1 milestone Nov 13, 2024
provokateurin
provokateurin requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm is unhappy, I think this needs to be fixed manually

@artonge
Copy link
Contributor

artonge commented Nov 13, 2024

No, IMetadataVersion does not exist in 28. Closing.

@artonge artonge closed this Nov 13, 2024
auto-merge was automatically disabled November 13, 2024 13:54

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin requested changes

@artonge artonge artonge approved these changes

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed bug feature: versions Items related to file versioning php Items related to PHP updates and code issues
Projects
None yet
Milestone
Nextcloud 28.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @provokateurin @XueSheng-GIT