-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenAPI #3324
feat: Add OpenAPI #3324
Conversation
d2b504b
to
ac3b696
Compare
I will try to extract some of the changes into separate PRs to get them merged first and then come back to this PR. |
ac3b696
to
42e92ba
Compare
I removed everything not strictly necessary to implement this. Some improvements can just be done later, like nextcloud/openapi-extractor#172. |
The Cypress failure is not related to the changes, I get the same errors on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing all the id indexing, is that so bad?
Also, why the snake_case on string ids, do we have a convention about that in OCS?
Not really, but I just removed it because it is never used.
No, I just wanted to make them all consistent. |
True, I think array caused really some unwanted issues :(
I think we use camelCase for both PHP and JS variables and for JS working with camelCase JSON is more convenient. So if we somewhen might consider a codestyle also JSON camelCase would be nice |
Ok, fair enough :) |
Also the code on the frontend side was very hacky in this regard, it is a lot better now. |
42e92ba
to
7bc43c4
Compare
Depends on #3407 and nextcloud/openapi-extractor#181. |
Signed-off-by: provokateurin <[email protected]>
7bc43c4
to
8c0d537
Compare
All depending PRs are merged, so this is finally ready. |
Still waiting for a review from @come-nc before merging to ensure I addressed all previous problems. |
Thanks a lot everyone! 🎉 |
Closes #3208
This is a "breaking" change to the API, but since it was not usable before due to CSRF restrictions it doesn't matter.While working on this I also had to cleanup a lot of the internal typings which resulted in this relatively large change for adding OpenAPI.
If this is too big please let me know and I will try to split it up.