Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Command/ExpireGroupBase: add type declarations #2768

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

joshtrichards
Copy link
Member

No description provided.

@joshtrichards joshtrichards added 3. to review Items that need to be reviewed technical debt labels Jan 17, 2024
@come-nc
Copy link
Contributor

come-nc commented Jan 30, 2024

2024-01-17T16:03:13.7504231Z ##[error]lib/Command/ExpireGroup/ExpireGroupTrash.php:44:2: MethodSignatureMismatch: Method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupTrash::configure with return type '' is different to return type 'void' of inherited method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupBase::configure (see https://psalm.dev/042)
2024-01-17T16:03:13.7520605Z ##[error]lib/Command/ExpireGroup/ExpireGroupTrash.php:51:2: MethodSignatureMismatch: Method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupTrash::execute with return type '' is different to return type 'int' of inherited method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupBase::execute (see https://psalm.dev/042)
2024-01-17T16:03:13.7531567Z ##[error]lib/Command/ExpireGroup/ExpireGroupVersions.php:45:2: MethodSignatureMismatch: Method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupVersions::configure with return type '' is different to return type 'void' of inherited method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupBase::configure (see https://psalm.dev/042)
2024-01-17T16:03:13.7540223Z ##[error]lib/Command/ExpireGroup/ExpireGroupVersions.php:52:2: MethodSignatureMismatch: Method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupVersions::execute with return type '' is different to return type 'int' of inherited method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupBase::execute (see https://psalm.dev/042)
2024-01-17T16:03:13.7548524Z ##[error]lib/Command/ExpireGroup/ExpireGroupVersionsTrash.php:46:2: MethodSignatureMismatch: Method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupVersionsTrash::configure with return type '' is different to return type 'void' of inherited method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupBase::configure (see https://psalm.dev/042)
2024-01-17T16:03:13.7557058Z ##[error]lib/Command/ExpireGroup/ExpireGroupVersionsTrash.php:53:2: MethodSignatureMismatch: Method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupVersionsTrash::execute with return type '' is different to return type 'int' of inherited method OCA\GroupFolders\Command\ExpireGroup\ExpireGroupBase::execute (see https://psalm.dev/042)

Commands inheriting the base class needs to be adapted

@joshtrichards joshtrichards self-assigned this Jan 30, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv skjnldsv added 2. developing Items that are currently under development and removed 3. to review Items that need to be reviewed labels Aug 28, 2024
@skjnldsv skjnldsv marked this pull request as draft August 30, 2024 09:32
@provokateurin provokateurin marked this pull request as ready for review September 15, 2024 16:54
@provokateurin provokateurin merged commit bb91790 into master Sep 15, 2024
43 checks passed
@provokateurin provokateurin deleted the jr/command-expireGroupBase-types branch September 15, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Items that are currently under development feedback-requested technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants