Fix expire commands and background job when trash and/or version apps are disabled #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable23 |
This was referenced Dec 30, 2021
fschrempf
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Overall this looks good to me, but I'm not familiar enough with the codebase to provide a thorough review at the moment. It would be good if someone could do a bit of testing with the different cases (trash & versions disabled, trash enabled, versions enabled, trash & versions enabled).
Pytal
reviewed
Jan 6, 2022
CarlSchwan
force-pushed
the
fix/optional-dependencies
branch
3 times, most recently
from
9940ac5
to
49a3e10
Compare
… are disabled Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
fix/optional-dependencies
branch
from
49a3e10
to
bc21eee
Compare
come-nc
approved these changes
Jan 6, 2022
|
Tested with the 4 combinations and everything work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1815
Fix #1812
For the background jobs, split the version expiration and trash expiration in two separate jobs. Both use the same placeholder in case the respective app is not enabled.
For the commands, create 4 different versions (using inheritance) with the 4 different combo enabled/disabled.
Signed-off-by: Carl Schwan [email protected]