This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Bind scroll event to window #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like in the filelist app binding the scroll event to $(window) works. This fixes #459 and enables app loading more than the initially loaded images. Signed-off-by: Christian Ingenhaag <[email protected]>
skjnldsv
approved these changes
Aug 19, 2018
skjnldsv
requested review from
oparoz,
MorrisJobke,
rullzer,
danxuliu and
juliusknorr
skjnldsv
added
bug
MorrisJobke
approved these changes
Aug 24, 2018
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #459
Licence: MIT or AGPL
Description
Like in the filelist app binding the scroll event to $(window) works. This fixes #459 and enables app loading more than the initially loaded images.
Tests
Test plan
Open a folder in gallery with many pictures ( > 100). Try to scroll down and check if all images are loaded.
Tested on