Include version number in firstrunwizard #563
Conversation
szaimen
force-pushed
the
enh/82/incloude-version-number
branch
2 times, most recently
from
3aac6b4
to
007836c
Compare
szaimen
requested review from
juliusknorr,
jancborchardt,
nimishavijay and
schiessle
|
Looks good code wise but please have a quick look @nextcloud/designers :) |
szaimen
force-pushed
the
enh/82/incloude-version-number
branch
from
e2dcefd
to
6c68614
Compare
templates/page.values.php
Outdated
| @@ -50,5 +50,8 @@ | |||
| </ul> | |||
|
|
|||
| <p class="details-link"><a href="<?php p($theme->getBaseUrl()); ?>" target="_blank" rel="noreferrer noopener"><?php p($l->t('Learn more about %s', $theme->getName())); ?></a></p> | |||
| <div style="text-align: center;"> | |||
| <h3><?php p($l->t('This Nextcloud is on version %s', [ \OC_Util::getVersionString() ])); ?></h3> | |||
There was a problem hiding this comment.
As the rest of the steps use the theme name a lot I would suggest something more like :
$theme->getName() is using Nextcloud version %s
If the theme name is set, of course.
There was a problem hiding this comment.
Hm... I would actually rather do that in a follow up to this PR...
@juliushaertl is that fine?
There was a problem hiding this comment.
If we do show the version here, it should be rather short and inconspicuous. :) And it’s not a h3, a <p> with color: var(--text-maxcontrast); would be better.
There was a problem hiding this comment.
done
This is how it looks now:
Signed-off-by: szaimen <[email protected]> Co-Authored-By: Julius Härtl <[email protected]>
szaimen
force-pushed
the
enh/82/incloude-version-number
branch
from
6c68614
to
c9e70b6
Compare
szaimen
requested review from
jancborchardt
and removed request for
jancborchardt
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
Fix #82
Signed-off-by: szaimen [email protected]