Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pdf-viewer sizing #845

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix pdf-viewer sizing #845

merged 1 commit into from
Nov 3, 2023

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Oct 26, 2023 •
edited
Loading

Fix #843

Before After
image image

@szaimen szaimen added this to the Nextcloud 28 milestone Oct 26, 2023
@szaimen szaimen mentioned this pull request Oct 26, 2023
Closed
@szaimen szaimen marked this pull request as ready for review October 26, 2023 12:20
danxuliu
danxuliu previously requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking at least until nextcloud/viewer#2030 is clarified.

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@szaimen szaimen requested a review from danxuliu November 1, 2023 10:14
@szaimen szaimen mentioned this pull request Nov 1, 2023
Closed
@skjnldsv
Copy link
Member

skjnldsv commented Nov 1, 2023

How does it behaves with the sidebar or other menus?

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 1, 2023

How does it behaves with the sidebar or other menus?

Works:
image

@szaimen szaimen requested review from juliusknorr, skjnldsv and danxuliu and removed request for juliusknorr, skjnldsv and danxuliu November 3, 2023 08:12
skjnldsv
skjnldsv approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 3, 2023

/compile

@szaimen @nextcloud-command
fix pdf-viewer sizing
a9c11bc 
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@szaimen szaimen merged commit 2af477c into master Nov 3, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/843/fix-sizing branch November 3, 2023 08:52
danxuliu
danxuliu reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am late to the party, but... tested and works 👍

Nice fix :-D

@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

PDF-viewer not full-screen anymore on NC28
3 participants
@szaimen @skjnldsv @danxuliu