Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Fix npm audit #765

Merged
merged 6 commits into from
Jul 12, 2023
Merged

[stable25] Fix npm audit #765

merged 6 commits into from
Jul 12, 2023

Conversation

nextcloud-command
Copy link
Contributor

Auto-generated fix of npm audit

@nextcloud-command nextcloud-command added 3. to review dependencies Pull requests that update a dependency file labels Jun 25, 2023
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable25-fix-npm-audit branch from bbf27cd to e264086 Compare July 2, 2023 03:28
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable25-fix-npm-audit branch from e264086 to 8c12e35 Compare July 9, 2023 03:54
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable25-fix-npm-audit branch from 8c12e35 to c757d44 Compare July 10, 2023 14:19
@szaimen szaimen requested a review from danxuliu July 10, 2023 14:20
@blizzz blizzz mentioned this pull request Jul 10, 2023
Merged
@blizzz blizzz requested a review from szaimen July 10, 2023 15:25
@blizzz
Copy link
Member

blizzz commented Jul 10, 2023

CI appears unhappy

@danxuliu
Replace license name with SPDX expression
34b7963 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu
Add missing file extensions in imports
6ed8566 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu
Remove outdated comment
57b0a16 
Since PDF.js was bumped to 2.5.207 in 4705de4 the event listened to
is "DOMContentLoaded" rather than "webviewerloaded".

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu
Remove blank lines at the beginning of the file
1c9999c 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@danxuliu
Copy link
Member

/compile /

@nextcloud-command
chore(assets): Recompile assets
3c0065d 
Signed-off-by: nextcloud-command <[email protected]>
szaimen
szaimen approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

danxuliu
danxuliu approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Smoke) Tested and works 👍

CI failures are unrelated (failed to setup the environment for the PHPUnit workers), so they can be fixed in another pull request.

@danxuliu danxuliu merged commit 55e871b into stable25 Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the automated/noid/stable25-fix-npm-audit branch July 12, 2023 11:30
@danxuliu danxuliu mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@danxuliu danxuliu danxuliu approved these changes

Assignees
No one assigned
Labels
4. to release dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Nextcloud 25.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@nextcloud-command @blizzz @danxuliu @szaimen