Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add capabilities to app. resolves issue #173 #194

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

sorbaugh
Copy link
Contributor

resolves #173

Tested locally via OCS API call /ocs/v2.php/cloud/capabilities

Capability is called "downloadlimit" under Files

Bildschirmfoto 2023-09-19 um 10 19 33

lib/Capabilities.php Outdated Show resolved Hide resolved
@sorbaugh
Copy link
Contributor Author

Done^^ We could think about refactoring other capabilities to this structure as well, however can't say how many clients that would break, so probably best to leave it alone for now.

lib/Capabilities.php Outdated Show resolved Hide resolved
@AndyScherzinger
Copy link
Member

Yeah, let's not touch other capabilities for exactly that reason 👍

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv skjnldsv merged commit 393e8ae into master Oct 4, 2023
10 of 11 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/sorbaugh/files-download-capabilities branch October 4, 2023 06:17
@AndyScherzinger
Copy link
Member

can you do a release @skjnldsv ? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capability
3 participants