Upload of icons #46
Merged
Upload of icons #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MariusBluem want to test this? Would be cool 😅 |
|
Could we hide this „Durchsuchen“-box and simply show only the upload button (a bit larger)? |
nickvergessen
force-pushed
the
upload-of-icons
branch
from
809a0b0 to
9b72ea1
Compare
|
Fixed, please review |
LukasReschke
requested changes
Sep 13, 2017
There was a problem hiding this comment.
- If I upload an image not matching the sizes the UI is blocked:
{"error":"Provided image is not a square with 16, 24 or 32 pixels width"}
Uncaught TypeError: Cannot read property 'message' of undefined
at HTMLInputElement.fail (https://10.211.55.7/stable9/apps/external/js/admin.js?v=96b21b17f7a0be8424d016de91703f8d-0:404:52)
at e.(anonymous function).(anonymous function)._trigger (https://10.211.55.7/stable9/core/vendor/core.js?v=96b21b17f7a0be8424d016de91703f8d-0:13:10075)
at e.(anonymous function).(anonymous function)._onFail (https://10.211.55.7/stable9/apps/files/js/jquery.fileupload.js?v=96b21b17f7a0be8424d016de91703f8d-0:876:18)
at e.(anonymous function).(anonymous function)._onFail (https://10.211.55.7/stable9/core/vendor/core.js?v=96b21b17f7a0be8424d016de91703f8d-0:13:5077)
at Object.<anonymous> (https://10.211.55.7/stable9/apps/files/js/jquery.fileupload.js?v=96b21b17f7a0be8424d016de91703f8d-0:910:30)
at j (https://10.211.55.7/stable9/core/vendor/core.js?v=96b21b17f7a0be8424d016de91703f8d-0:2:26925)
at Object.fireWith [as rejectWith] (https://10.211.55.7/stable9/core/vendor/core.js?v=96b21b17f7a0be8424d016de91703f8d-0:2:27738)
at x (https://10.211.55.7/stable9/core/vendor/core.js?v=96b21b17f7a0be8424d016de91703f8d-0:4:11278)
at XMLHttpRequest.<anonymous> (https://10.211.55.7/stable9/core/vendor/core.js?v=96b21b17f7a0be8424d016de91703f8d-0:4:14765)
|
Fixed 🙈 |
MariusBluem
approved these changes
Sep 28, 2017
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
upload-of-icons
branch
from
0822ad9 to
8df44d5
Compare
Signed-off-by: Joas Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16
Fix #5
Partly #36