Implementation of Target_Blank option to open External links in a new tab #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christophe canovas <[email protected]>
ChrisCano66
force-pushed
the
OpenInNewTab
branch
from
35f85db
to
e1dab82
Compare
|
Linked to nextcloud/server#27725 |
|
From my POV the "Redirect" option can be reused to keep it simpler: A page that needs redirecting is good to leave the origin tab behind so you still find back to your Nextcloud, same that would happen when you |
almulder
approved these changes
Nov 30, 2021
1 task
|
Replaced by #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #79
** External Issue : #74 "Open in new tab"**
Hi !
We are a team that contributes to the improvement and production of free software for the general public. Moreover, being a NextCloud user, we wanted to improve it and especially the External module.
Thus, we wanted to respond to Issue #74 which requires the opening of external links to a new tab.
We have therefore improved the source code of the External module by modifying the following:
On External front-end, we added the possibility to check the "New Tab" option.
We have modified the files "admin.js", "site.handlebars" and "style.css" in the External module where we added a "target" option.
But we needed to modify some Nextcloud files too : "layout.user.php" and "MainMenu.js". So we also made a contribution on NextCloud Server in order for the implementation to be done properly.
For setting up the data option in the database and link the front-end to back-end, we had to modify the following files in External module :
"Application.php", "APIController.php", "SitesManager.php", "Personnal.php", "BeforeTemplateRenderedListener.php" and " Capabilites.php".
In all of this files, we added the "target" option which allows us to follow the activation of the front-end option to the back-end and the database.
If you have any questions about the implementation of the option, please do not hesitate to contact us by email at the following address: [email protected] or [email protected].
Regards,
/!\ Careful /!\
The compatibility between the "redirect" option and the "target" option can sometimes create a bug and are not necessarily compatible. But the use of both options at the same time is possible and feature on mozilla/firefox/chrome. However, it is preferable to use either option and not both at the same time.
/!\ Careful /!\