Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devmanual): Add user managers doc #10355

Merged
merged 1 commit into from
May 10, 2023
Merged

feat(devmanual): Add user managers doc #10355

merged 1 commit into from
May 10, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 10, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

image

@ChristophWurst ChristophWurst added this to the Nextcloud 27 milestone May 10, 2023
@ChristophWurst ChristophWurst self-assigned this May 10, 2023
julien-nc
julien-nc approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch it's quite confusing to use IUserManager to get user objects that have the getManagerUids and setManagerUids methods.

@ChristophWurst
Copy link
Member Author

What would be the alternative? The managers are a property of the user, like their email addresses, location, etc.

@ChristophWurst
Copy link
Member Author

Do you mean the user manager and the user's manager to be confusing? Then yes :s

@ChristophWurst ChristophWurst mentioned this pull request May 10, 2023
Merged
10 tasks
@julien-nc
Copy link
Member

julien-nc commented May 10, 2023 •
edited
Loading

Do you mean the user manager and the user's manager to be confusing? Then yes :s

@ChristophWurst Yes but I don't see what we can do to make it clearer. Anyway, the user manager class is only used by developers. Let's say it's fine 😁.

@ChristophWurst
Copy link
Member Author

One day we will rename the IUserManager https://stackoverflow.com/questions/1866794/naming-classes-how-to-avoid-calling-everything-a-whatevermanager

@ChristophWurst ChristophWurst merged commit 4fd6a8a into master May 10, 2023
@ChristophWurst ChristophWurst deleted the feat/devmanual/user-managers branch May 10, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release enhancement manual: developer
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @julien-nc