-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update with-nginx-proxy/mariadb-cron-redis/fpm/docker-compose.yml #514
Conversation
Tockra
commented
Oct 15, 2018
- Changed version to 10.3 because: Deadlock Problem with mariadb:latest #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
Changed version to 10.3 because: #503 Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503 - Added "--log-bin=mysqld-bin" caused of startup Warning.
Can you put #505 here too? Thanks! |
Okay, sorry I'm not so familar with git and the problem at first was I added the changes via github webpanel. |
No ptoblems, we are all learning ;) I recommend reading https://nvie.com/posts/a-successful-git-branching-model/ Coming back to our PR: This bin log argument, can you point me to the documents that states that it was not needed before and is needed now? I'm curious. Thanks a lot for your contribution. I'm curious about the thoughts of other maintainers? |
There is no documentation about it but if you don't use log-bin you'll get this warning: |
Ok, so this fixes the warning, sounds legit to me. |
I don't know why it doesn't work. But I think to pin the version until it is fixed is a good idea. |
Merge or not merge that is the question!? |
|
That is wrong: https://hub.docker.com/_/mariadb |
Yes, meanwhile |
I remember that at the moment I posted this Issue 10.3 wasn't equal latest. |
Are you using Redis for file locking as recommend? |