Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoconfiguration for S3 as Primary Storage #1124

Closed
rkilchmn opened this issue May 22, 2020 · 4 comments · Fixed by #1227
Closed

Autoconfiguration for S3 as Primary Storage #1124

rkilchmn opened this issue May 22, 2020 · 4 comments · Fixed by #1227

Comments

@rkilchmn
Copy link

rkilchmn commented May 22, 2020 •
edited
Loading

It would be great if S3 Primary Storage could be auto-configured similar to the database or Redis settings. Changing the primary storage in the config file after the installation step leads to some strange effects and prohibits a "serverless" deployment where there is no persistent file system other than S3. All file system extensions i looked up for docker requires root access in the container which are not given for serverless deployment options such as AWS Fargate
@vdeville
Copy link

+1 to add the possibility to configure S3 via env variable like this:

      - S3_KEY=xxx
      - S3_SECRET=xxxx
      - S3_BUCKET=xx-test01
      - S3_ADDRESS=xxx
      - S3_REGION=fr-par
      - S3_SSL=true
      - S3_PORT=443
      - S3_AUTOCREATE=false

@pankid
Copy link

pankid commented Jul 4, 2020

Would also love to see this feature.

@cuppett
Copy link
Contributor

cuppett commented Aug 21, 2020

See also #1134 (with a PR).

@cuppett cuppett linked a pull request Aug 21, 2020 that will close this issue
Resolves #1124, Resolves #1134: Configure S3 (or compatible) as primary storage through environment variables #1135
Closed
@pierreozoux pierreozoux mentioned this issue Aug 25, 2020
Closed
@cuppett cuppett linked a pull request Aug 25, 2020 that will close this issue
Adds ability to configure S3 object stores via environment variables #1193
Closed
pierreozoux added a commit that referenced this issue Aug 28, 2020
@pierreozoux @adamjenkins1 @cuppett
Adds ability to configure S3 object stores via environment variables
a5d18c6 
closes #1193 #1124 #1134

Co-authored-by: Adam Jenkins <[email protected]>
Co-authored-by: Stephen Cuppett <[email protected]>
@pierreozoux pierreozoux mentioned this issue Aug 28, 2020
Merged
pierreozoux added a commit that referenced this issue Aug 28, 2020
@pierreozoux @adamjenkins1 @cuppett
Adds ability to configure S3 object stores via environment variables
47032fd 
closes #1193 #1124 #1134

Co-authored-by: Adam Jenkins <[email protected]>
Co-authored-by: Stephen Cuppett <[email protected]>
pierreozoux added a commit that referenced this issue Aug 28, 2020
@pierreozoux @adamjenkins1 @cuppett
Adds ability to configure S3 object stores via environment variables
2041477 
closes #1193 #1124 #1134

Co-authored-by: Adam Jenkins <[email protected]>
Co-authored-by: Stephen Cuppett <[email protected]>
@pierreozoux pierreozoux mentioned this issue Aug 28, 2020
Merged
@cuppett cuppett linked a pull request Aug 28, 2020 that will close this issue
Adds ability to configure S3 object stores via environment variables #1227
Merged
pierreozoux added a commit that referenced this issue Aug 29, 2020
@pierreozoux @adamjenkins1 @cuppett
Adds ability to configure S3 object stores via environment variables (#…
27c54cd 
…1227)

* Adds ability to configure S3 object stores via environment variables

closes #1193 #1124 #1134

Co-authored-by: Adam Jenkins <[email protected]>
Co-authored-by: Stephen Cuppett <[email protected]>

* Update .config/s3.config.php

Co-authored-by: Adam Jenkins <[email protected]>
Co-authored-by: Stephen Cuppett <[email protected]>
@rkilchmn
Copy link
Author

Awesome! Great work and thanks for everyone who contributed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cuppett @vdeville @pankid @rkilchmn