Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop recipes with unsupported - outdated - PHP versions #600

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 20, 2023

Keep the images but drop the recipes as they no longer used and make the repo very crowded.
(This is git if you need them just look in the git log 😉 )

@nickvergessen
Copy link
Member

Kind of yolo, but if others agree, I would be fine

@susnux susnux requested a review from szaimen October 20, 2023 14:50
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but not sure if we dont need them later possibly?
cc @blizzz

@susnux
Copy link
Contributor Author

susnux commented Oct 20, 2023

Fine by me but not sure if we don't need them later possibly?

The images are preserved, but the recipes are just dropped form master (see referenced issue we dropped support for those versions with NC18 and NC20).

blizzz
blizzz previously requested changes Nov 1, 2023
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep 7.1 and above, for the unlikely case someone comes up with something against the oldest possible supported enterprise major.

@susnux
Copy link
Contributor Author

susnux commented Nov 1, 2023

@blizzz those images are still provided just the recipes are removed from master branch.

@blizzz
Copy link
Member

blizzz commented Nov 1, 2023

@blizzz those images are still provided just the recipes are removed from master branch.

Sure, but it'll be uncomfortable to update or change any of them. It does not hurt having them lying around a little longer. It's unlikely, yet there is not pressing need to remove them early, or is there?

@susnux
Copy link
Contributor Author

susnux commented Nov 1, 2023

@blizzz Ok reverted all php7.1 and 7.2

@blizzz blizzz merged commit 216923a into master Nov 2, 2023
2 checks passed
@blizzz blizzz deleted the chore/drop-unsupported branch November 2, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop obsolete versions of PHP
5 participants