-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop recipes with unsupported - outdated - PHP versions #600
Conversation
Kind of yolo, but if others agree, I would be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me but not sure if we dont need them later possibly?
cc @blizzz
The images are preserved, but the recipes are just dropped form master (see referenced issue we dropped support for those versions with NC18 and NC20). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep 7.1 and above, for the unlikely case someone comes up with something against the oldest possible supported enterprise major.
@blizzz those images are still provided just the recipes are removed from master branch. |
Sure, but it'll be uncomfortable to update or change any of them. It does not hurt having them lying around a little longer. It's unlikely, yet there is not pressing need to remove them early, or is there? |
071c837
to
b7bed8f
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
b7bed8f
to
7638441
Compare
@blizzz Ok reverted all php7.1 and 7.2 |
Keep the images but drop the recipes as they no longer used and make the repo very crowded.
(This is git if you need them just look in the git log 😉 )