Add new update channels part 2. #6790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
force-pushed
the
feature/update-channel-2
branch
from
53b6f9b
to
b88d1dd
Compare
camilasan
force-pushed
the
feature/update-channel-2
branch
3 times, most recently
from
106bb08
to
952526a
Compare
camilasan
force-pushed
the
feature/update-channel-2
branch
from
952526a
to
206b815
Compare
claucambra
requested changes
Jul 4, 2024
mgallien
requested changes
Jul 4, 2024
mgallien
requested changes
Jul 4, 2024
camilasan
force-pushed
the
feature/update-channel-2
branch
from
5b5f6a7
to
926d060
Compare
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…channel. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
The default should be what is returned by defaultUpdateChannel() when desktopEnterpriseChannel is not available. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…nd what info to show the user. Signed-off-by: Camila Ayres <[email protected]>
…erprise. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Subscription and channel are supposed to be a general setting, not per user. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…or string. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
feature/update-channel-2
branch
from
926d060
to
9bd4ef1
Compare
mgallien
approved these changes
Jul 4, 2024
|
AppImage file: nextcloud-PR-6790-9bd4ef1b83e1e7a93bc3017f01980e02ab739dfa-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/nextcloud-gmbh/desktop/issues/26
This should:
check for server capability
hasValidSubscription' => true,
desktopEnterpriseChannel => stable/enterprise
if set -> Desktop asks update server for channel=enterprise
it is automatically enabled for all customer
user can still "downgrade" to stable (will then be remembered)
if the client is branded: