Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of NextcloudFileProviderKit in File Provider Module #6642

Merged
merged 29 commits into from
Apr 17, 2024
Merged

Make use of NextcloudFileProviderKit in File Provider Module #6642

merged 29 commits into from
Apr 17, 2024

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra
Add test target for file provider testing
af9a271 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Database manager does not need to be an NSObject
2caa43a 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Allow NextcloudFilesDatabaseManager to take a specific realmconfig in…
3066f58 
… constructor

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove FileProviderExtTests
3c3e3aa 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add NextcloudFileProviderKit dependency
e7616e0 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove use of all code now available in NextcloudFileProviderKit
b9483f0 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use Enumerator in NextcloudFileProviderKit
5a77475 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use FileProviderItem from NextcloudFileProviderKit
2c0688f 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Make use of NextcloudFileProviderKit materialisedenumerationobserver
913d724 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Adapt to new NextcloudFileProviderKit item nomenclature
e8d1afa 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Fix build of ShareTableViewDataSource
1f78b9f 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use thumbnail fetching procedure from NCFPK
d74d23c 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use new convenience method to get Item for root container from NCFPK
6200cab 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Greatly simplify item method of FIleProviderExtension by using item s…
788fd7f 
…toredItem method

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Simplify FileProviderExtension's deleteItem method by leveraging Item…
3ec18ba 
…'s delete method

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use fetchContents from NCFPK item
2373cd4 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use NCFPK Item.create in createItem
c9a1317 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use NCFPK item modify method
485b07a 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Improve logging in delete item procedure of FPExt
dab28f2 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Fix passing of wrong item into item.modify
c082c44 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove unused components in FileProviderExt
9e7ce16 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Correctly set up NCKit instance with account string
7664509 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Provide NCFPK enumerator with extension domain
33e2c08 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Always signal enumerator after errors to try and recover from what th…
6a64248 
…e error might have been

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add change observer from NCFPK
68370ad 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove client-side push notification handling for file provider exten…
5977a7c 
…sion in favour of simply using NCFPK remote change observer

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Set changeobserver as delegate for nkcommon
77f9096 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove now-unneeded Realm dependency from FileProviderExt
dff6428 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Pin NextcloudFileProviderKit version to 0.9.0 (up to next major version)
f0f995c 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra self-assigned this Apr 17, 2024
@claucambra claucambra merged commit aeca31a into master Apr 17, 2024
9 of 12 checks passed
@claucambra claucambra deleted the bugfix/file-provider-testing branch April 17, 2024 08:21
@claucambra
Copy link
Collaborator Author

/backport to stable-3.13

@backportbot backportbot bot mentioned this pull request Apr 17, 2024
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6642-f0f995c2607870fca20af8df3eb005ae7b8c2bc7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien added this to the 3.14.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @tobiasKaminsky @mgallien