Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments support #632

Merged
merged 30 commits into from
Oct 9, 2018
Merged

Comments support #632

merged 30 commits into from
Oct 9, 2018

Commits on Oct 9, 2018

  1. Add backend support for comments 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    d3027ac View commit details
    Browse the repository at this point in the history

  2. Load comments entity for app 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    41db5d0 View commit details
    Browse the repository at this point in the history

  3. Add basic comments frontend 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    339bc34 View commit details
    Browse the repository at this point in the history

  4. Add backbone comment classes 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2e824f0 View commit details
    Browse the repository at this point in the history

  5. Add comment event handler for activities 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    63337c1 View commit details
    Browse the repository at this point in the history

  6. Enhance activity list with comment data 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    ffd32a8 View commit details
    Browse the repository at this point in the history

  7. Add comment action menu 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    e547a5d View commit details
    Browse the repository at this point in the history

  8. Implement comment deletion and loading indicator 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    f5520d3 View commit details
    Browse the repository at this point in the history

  9. Sidebar design improvements 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    630a5ba View commit details
    Browse the repository at this point in the history

  10. Move contenteditable directive to separate file 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    ddeefd5 View commit details
    Browse the repository at this point in the history

  11. Properly inject ICommentsManager 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    63a34e7 View commit details
    Browse the repository at this point in the history

  12. Fix tests 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    e29efe8 View commit details
    Browse the repository at this point in the history

  13. Implement user mentioning in frontend 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    310af37 View commit details
    Browse the repository at this point in the history

  14. Inject user manager 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    e0ac86a View commit details
    Browse the repository at this point in the history

  15. Fix eslint errors 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    97b7bca View commit details
    Browse the repository at this point in the history

  16. Fix styling and proper template rendering 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    93c3c54 View commit details
    Browse the repository at this point in the history

  17. Send notification on user mention 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    f66f4e0 View commit details
    Browse the repository at this point in the history

  18. Use board users for @-mentioning 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    691c72d View commit details
    Browse the repository at this point in the history

  19. Fix jslint errors 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    46720dc View commit details
    Browse the repository at this point in the history

  20. Implement editing comments 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    dcc3601 View commit details
    Browse the repository at this point in the history

  21. Add UI feedback for comment deletion 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    9363f86 View commit details
    Browse the repository at this point in the history

  22. Fix issue when switching between cards 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    5f8c46b View commit details
    Browse the repository at this point in the history

  23. Fix unread comment count 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    3e8451e View commit details
    Browse the repository at this point in the history

  24. Fix racecondition during loading of comments 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    3a36f7d View commit details
    Browse the repository at this point in the history

  25. Fix user id in mention notification 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    cb3c083 View commit details
    Browse the repository at this point in the history

  26. Allow submit of comments using shift+enter 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    27f9707 View commit details
    Browse the repository at this point in the history

  27. Fix codacy issues 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    5edb95f View commit details
    Browse the repository at this point in the history

  28. Add unit tests for comment handling 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    da0cfdb View commit details
    Browse the repository at this point in the history

  29. Add test for mention notifications 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    68880fc View commit details
    Browse the repository at this point in the history

  30. Tests: Comment actrivity parsing 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr
    juliusknorr committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    4779d3a View commit details
    Browse the repository at this point in the history