Skip to content

Commit

Permalink
chore: Cleanup some outdated fixme comments
Browse files Browse the repository at this point in the history
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
juliusknorr committed Aug 11, 2023
1 parent caebc01 commit 6672843
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion lib/Service/Importer/BoardImportCommandService.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ public function getOutput(): OutputInterface {
}

protected function validateConfig(): void {
// FIXME: Make config optional for deck plain importer (but use a call on the importer insterad)
try {
$config = $this->getInput()->getOption('config');
if (!$config) {
Expand Down
3 changes: 0 additions & 3 deletions lib/Service/Importer/Systems/DeckJsonService.php
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ public function getStacks(): array {
$card->stackId = $index;
$this->tmpCards[] = $card;
}
// TODO: check older exports as currently there is a bug that adds lists to it with different index
}
}
return $return;
Expand Down Expand Up @@ -221,7 +220,6 @@ public function getAclList(): array {
$board = $this->getImportService()->getData();
$return = [];
foreach ($board->acl as $aclData) {
// FIXME: Figure out mapping
$acl = new Acl();
$acl->setBoardId($this->getImportService()->getBoard()->getId());
$acl->setType($aclData->type);
Expand All @@ -236,7 +234,6 @@ public function getAclList(): array {
if ($participant) {
$return[] = $acl;
}
// TODO: Once we have error collection we should catch non-existing users
}
return $return;
}
Expand Down

0 comments on commit 6672843

Please sign in to comment.