Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nextcloud vue 8.0.0 #3695

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Upgrade to Nextcloud vue 8.0.0 #3695

merged 1 commit into from
Nov 9, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 8, 2023

Breaking changes:

@GretaD GretaD added enhancement New feature or request 3. to review Waiting for reviews labels Nov 8, 2023
@GretaD GretaD self-assigned this Nov 8, 2023
@ChristophWurst
Copy link
Member

Any incompatibilities with 27 or older?

@susnux
Copy link

susnux commented Nov 8, 2023

Any incompatibilities with 27 or older?

If you use the right sidebar then it will be inconsistent from UI

@ShGKme
Copy link

ShGKme commented Nov 8, 2023

  • feat(NcEmptyContent)!: make empty content centered by default instead of 20vh margin by @ShGKme in #4506

This requires either adding height: 100% to the <NcEmptyContent> or using it in a stretched flex container.

@ShGKme ShGKme closed this Nov 8, 2023
@ShGKme ShGKme reopened this Nov 8, 2023
@ShGKme
Copy link

ShGKme commented Nov 8, 2023

Sorry, suddenly touched a button when the cursor was on the "close" button 🙈

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1611f5e) 2.06% compared to head (f8d944d) 0.00%.
Report is 2 commits behind head on main.

❗ Current head f8d944d differs from pull request most recent head bf09081. Consider uploading reports for the commit bf09081 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3695      +/-   ##
==========================================
- Coverage     2.06%   0.00%   -2.07%     
- Complexity       0     261     +261     
==========================================
  Files           89      24      -65     
  Lines         5365     784    -4581     
  Branches      1504       0    -1504     
==========================================
- Hits           111       0     -111     
+ Misses        5134     784    -4350     
+ Partials       120       0     -120     
Files Coverage Δ
lib/Listener/LoadContactsFilesActions.php 0.00% <0.00%> (ø)

... and 112 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD
Copy link
Contributor Author

GretaD commented Nov 8, 2023

Any incompatibilities with 27 or older?

If you use the right sidebar then it will be inconsistent from UI

we dont :)

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jumping contacts issue is not resolved yet but I am unsure where that originates. Can't inspect the app with Vue Dev Tools either.

@GretaD
Copy link
Contributor Author

GretaD commented Nov 8, 2023

The jumping contacts issue is not resolved yet but I am unsure where that originates. Can't inspect the app with Vue Dev Tools either.

i cannot reproduce it. if someone else can test and see if they can

package.json Outdated Show resolved Hide resolved
src/components/ContactsList.vue Outdated Show resolved Hide resolved
src/components/OrgChart.vue Show resolved Hide resolved
@ChristophWurst ChristophWurst merged commit 49e252d into main Nov 9, 2023
26 of 27 checks passed
@ChristophWurst ChristophWurst deleted the update/vue-8 branch November 9, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants