Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): use latest StorageWrapper signature #1534

Closed
wants to merge 1 commit into from
Closed

fix(storage): use latest StorageWrapper signature #1534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ACL/ACLStorageWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
parent::is_file($path);
}

public function stat($path) {
public function stat(string $path): array|false {

Check failure on line 167 in lib/ACL/ACLStorageWrapper.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis

MethodSignatureMismatch 

lib/ACL/ACLStorageWrapper.php:167:30: MethodSignatureMismatch: Argument 1 of OCA\Collectives\ACL\ACLStorageWrapper::stat has wrong type 'string', expecting '' as defined by OCP\Files\Storage\IStorage::stat (see https://psalm.dev/042)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function stat(string $path): array|false {
public function stat($path): array|false {

if (!$this->checkPermissions(Constants::PERMISSION_READ)) {
return false;
}
Expand Down
Loading