Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to typed properties and IInitialState #4282

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Jun 13, 2022

And a few extras

Needs #4279

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts and prayers for the backport bot

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.87%. Comparing base (aadc104) to head (b211fc7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4282      +/-   ##
============================================
- Coverage     23.31%   22.87%   -0.44%     
  Complexity      442      442              
============================================
  Files           247      247              
  Lines         11444    11369      -75     
  Branches       1923     1923              
============================================
- Hits           2668     2601      -67     
+ Misses         8776     8768       -8     
Flag Coverage Δ
javascript 14.59% <ø> (ø)
php 58.39% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcitworld tcitworld force-pushed the typed-properties branch 2 times, most recently from 40d843c to d49b15e Compare June 13, 2022 15:46
@ChristophWurst
Copy link
Member

conflicts mildly

miaulalala
miaulalala previously approved these changes Mar 13, 2023
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙏

@miaulalala
Copy link
Contributor

I need #5881 and #5882 to be sure everything's allright.

@miaulalala miaulalala added the blocked This ticket or PR is blocked by another one label Apr 4, 2024
@miaulalala
Copy link
Contributor

dog-welcome-to-hell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress blocked This ticket or PR is blocked by another one technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants