Create Talk rooms for appointments #4025

ChristophWurst · 2022-03-07T14:21:10Z

New database column
Front-end
- Add checkbox to modal (only render when Talk is enabled)
Adjust email template to show the link

codecov · 2022-03-07T14:23:06Z

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (cd6f8ab) 22.55% compared to head (0d86766) 22.59%.

❗ Current head 0d86766 differs from pull request most recent head 74fc70d. Consider uploading reports for the commit 74fc70d to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4025      +/-   ##
============================================
+ Coverage     22.55%   22.59%   +0.04%     
- Complexity      353      373      +20     
============================================
  Files           233      236       +3     
  Lines         11372    11475     +103     
  Branches       2144     2149       +5     
============================================
+ Hits           2565     2593      +28     
- Misses         8807     8882      +75

Flag	Coverage Δ
javascript	`14.02% <0.00%> (-0.02%)`	⬇️
php	`63.92% <ø> (-1.68%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/AppointmentConfigModal.vue	`0.00% <0.00%> (ø)`
...s/AppointmentConfigModal/CheckedDurationSelect.vue	`0.00% <ø> (ø)`
...rc/components/AppointmentConfigModal/TextInput.vue	`0.00% <0.00%> (ø)`
src/models/appointmentConfig.js	`0.00% <0.00%> (ø)`
src/store/settings.js	`87.71% <0.00%> (-0.78%)`	⬇️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tcitworld · 2022-03-17T19:18:36Z

lib/Listener/AppointmentBookedListener.php

+			return;
+		}
+
+		if (!$event->getConfig()->getCreateTalkRoom()) {


$event->getConfig() might as well be a local variable.

tcitworld · 2022-03-17T19:19:39Z

lib/Listener/AppointmentBookedListener.php

+		$broker->createConversation(
+			$event->getConfig()->getName(),
+			[$organizer],
+			$broker->newConversationOptions()->setPublic(false),


If the link is to be sent shouldn't the conversation be public if the attendee is not an user?

Yet I missed to make it public: #5516

ChristophWurst · 2022-03-22T15:50:55Z

Adjust email template to show the link

Right now there is only a verification email, not a confirmation email for the final booking. We'll have to add the latter to propagate the link. The verification email can't have the Talk link as we only create the conversation once the booking is confirmed.

ChristophWurst · 2022-10-31T10:30:26Z

It works

miaulalala · 2022-11-21T13:50:48Z

lib/Service/Appointments/BookingCalendarWriter.php

+						  string $displayName,
+						  string $email,
+						  ?string $description = null,
+						  ?string $location = null) : string {


The location is on the $config object (unless you want to refactor that and allow a talk room per booking, not per config?)

ChristophWurst · 2022-11-21T15:40:55Z

lib/Service/Appointments/BookingService.php

+			$booking->getDisplayName(),
+			$booking->getEmail(),
+			$booking->getDescription(),
+			$config->getCreateTalkRoom() ? $booking->getTalkUrl() : $config->getLocation(),


@miaulalala 👀 an appointment with a Talk room is implicitly taking place online, so there is no location to enter for the organizer and we will write the Talk URL instead

ChristophWurst · 2023-04-19T06:25:47Z

Linter is not happy yet

@hamza221 did you have to change anthing except resolveing conflicts? Then approve the PR if it works. I'm not allowed to review my own PR :)

lib/Migration/Version4004Date20230414163505.php

ChristophWurst · 2023-04-20T08:18:52Z

BUG when I click the checkbox Create a Talk room

[Vue warn]: Invalid prop: type check failed for prop "disabled". Expected Boolean, got Array

Edit: info.xml missing so the migration didn't run.

ChristophWurst · 2023-04-20T12:17:04Z

👍 on Hamza's latest state. The integration works.

Signed-off-by: Christoph Wurst <[email protected]>

ChristophWurst added the 2. developing Work in progress label Mar 7, 2022

ChristophWurst assigned ChristophWurst and JuliaKirschenheuter Mar 7, 2022

tcitworld reviewed Mar 17, 2022

View reviewed changes

ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels May 20, 2022

ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Oct 31, 2022

ChristophWurst unassigned JuliaKirschenheuter Oct 31, 2022

ChristophWurst added the enhancement New feature request label Oct 31, 2022

miaulalala reviewed Nov 21, 2022

View reviewed changes

ChristophWurst commented Nov 21, 2022

View reviewed changes

ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Apr 4, 2023

ChristophWurst removed their assignment Apr 4, 2023

hamza221 force-pushed the enhancement/create-talk-room-appointment branch from 4669ebc to eef6116 Compare April 18, 2023 20:45

hamza221 added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 18, 2023

hamza221 marked this pull request as ready for review April 18, 2023 20:46

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 19, 2023

tcitworld reviewed Apr 19, 2023

View reviewed changes

lib/Migration/Version4004Date20230414163505.php Show resolved Hide resolved

ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews 2. developing Work in progress labels Apr 20, 2023

ChristophWurst added the 3. to review Waiting for reviews label Apr 20, 2023

ChristophWurst force-pushed the enhancement/create-talk-room-appointment branch from fe69765 to ac52bb6 Compare April 20, 2023 11:50

ChristophWurst requested review from st3iny and hamza221 April 20, 2023 12:16

hamza221 approved these changes Apr 20, 2023

View reviewed changes

Create Talk rooms for appointments

74fc70d

Signed-off-by: Christoph Wurst <[email protected]>

ChristophWurst force-pushed the enhancement/create-talk-room-appointment branch from 0d86766 to 74fc70d Compare April 20, 2023 13:20

ChristophWurst enabled auto-merge April 20, 2023 13:21

ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 20, 2023

ChristophWurst merged commit 3db581f into main Apr 20, 2023

ChristophWurst deleted the enhancement/create-talk-room-appointment branch April 20, 2023 15:51

ChristophWurst added this to the v4.4.0 milestone May 2, 2023

ChristophWurst mentioned this pull request Aug 4, 2023

Revert "Revert "Create Talk rooms for appointments"" #5319

Merged

3 tasks

ChristophWurst mentioned this pull request Oct 4, 2023

fix(appointments): Make rooms public #5516

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Talk rooms for appointments #4025

Create Talk rooms for appointments #4025

ChristophWurst commented Mar 7, 2022 •

edited

Loading

codecov bot commented Mar 7, 2022 •

edited

Loading

tcitworld Mar 17, 2022

tcitworld Mar 17, 2022

ChristophWurst Oct 4, 2023

ChristophWurst commented Mar 22, 2022

ChristophWurst commented Oct 31, 2022

miaulalala Nov 21, 2022

ChristophWurst Nov 21, 2022

ChristophWurst commented Apr 19, 2023

ChristophWurst commented Apr 20, 2023 •

edited

Loading

ChristophWurst commented Apr 20, 2023

Create Talk rooms for appointments #4025

Create Talk rooms for appointments #4025

Conversation

ChristophWurst commented Mar 7, 2022 • edited Loading

codecov bot commented Mar 7, 2022 • edited Loading

Codecov Report

tcitworld Mar 17, 2022

Choose a reason for hiding this comment

tcitworld Mar 17, 2022

Choose a reason for hiding this comment

ChristophWurst Oct 4, 2023

Choose a reason for hiding this comment

ChristophWurst commented Mar 22, 2022

ChristophWurst commented Oct 31, 2022

miaulalala Nov 21, 2022

Choose a reason for hiding this comment

ChristophWurst Nov 21, 2022

Choose a reason for hiding this comment

ChristophWurst commented Apr 19, 2023

ChristophWurst commented Apr 20, 2023 • edited Loading

ChristophWurst commented Apr 20, 2023

ChristophWurst commented Mar 7, 2022 •

edited

Loading

codecov bot commented Mar 7, 2022 •

edited

Loading

ChristophWurst commented Apr 20, 2023 •

edited

Loading