-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow admins to hide event export buttons #3995
Allow admins to hide event export buttons #3995
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3995 +/- ##
============================================
+ Coverage 29.45% 29.47% +0.01%
Complexity 323 323
============================================
Files 220 220
Lines 7577 7583 +6
Branches 1002 1002
============================================
+ Hits 2232 2235 +3
- Misses 5345 5348 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Maybe I don't understand it, but how does that help without a change of server? The url is still accessible and serves the data. |
That is correct from a technical PoV. This is really about what options we give the users explicitly. The Files app has a similar feature. You can hide the download button, while technically files could still be acquired. It's 🤷 but also 🙈 to put it into emojis :) |
49fc0e3
to
03bb9ca
Compare
#3993 (comment) for more context :) |
03bb9ca
to
d46acc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
occ config:app:set calendar hide_event_download --value=yes Signed-off-by: Christoph Wurst <[email protected]>
d46acc5
to
6bf4d07
Compare
This contributes the first part of #3993.
The patch adds a simple config switch. There are shared environments where Nextcloud is only used on web and users are not supposed to export/download event data to a local disk.
I will update the admin calendar docs accordingly. The config switch can be done via CLI with