Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to hide event export buttons #3995

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Feb 25, 2022

This contributes the first part of #3993.

The patch adds a simple config switch. There are shared environments where Nextcloud is only used on web and users are not supposed to export/download event data to a local disk.

I will update the admin calendar docs accordingly. The config switch can be done via CLI with

php -f occ config:app:set calendar hideEventExport --value=yes
  • TODO rename download to export

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature request nextcloud-gmbh Tickets with importance for Nextcloud Gmbh labels Feb 25, 2022
@ChristophWurst ChristophWurst added this to the v3.2.0 milestone Feb 25, 2022
@ChristophWurst ChristophWurst self-assigned this Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #3995 (6bf4d07) into main (59cc000) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3995      +/-   ##
============================================
+ Coverage     29.45%   29.47%   +0.01%     
  Complexity      323      323              
============================================
  Files           220      220              
  Lines          7577     7583       +6     
  Branches       1002     1002              
============================================
+ Hits           2232     2235       +3     
- Misses         5345     5348       +3     
Flag Coverage Δ
javascript 20.82% <40.00%> (+<0.01%) ⬆️
php 67.44% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/views/Calendar.vue 0.00% <ø> (ø)
src/views/EditSidebar.vue 0.00% <0.00%> (ø)
src/views/EditSimple.vue 0.00% <0.00%> (ø)
src/store/settings.js 100.00% <100.00%> (ø)
...ud/apps/calendar/lib/Controller/ViewController.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59cc000...6bf4d07. Read the comment docs.

@raimund-schluessler
Copy link
Member

Maybe I don't understand it, but how does that help without a change of server? The url is still accessible and serves the data.

lib/Controller/ViewController.php Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member Author

Maybe I don't understand it, but how does that help without a change of server? The url is still accessible and serves the data.

That is correct from a technical PoV. This is really about what options we give the users explicitly. The Files app has a similar feature. You can hide the download button, while technically files could still be acquired. It's 🤷 but also 🙈 to put it into emojis :)

@ChristophWurst ChristophWurst force-pushed the enhancement/optionally-hide-event-download branch from 49fc0e3 to 03bb9ca Compare February 25, 2022 15:37
@ChristophWurst
Copy link
Member Author

Maybe I don't understand it, but how does that help without a change of server? The url is still accessible and serves the data.

#3993 (comment) for more context :)

@ChristophWurst ChristophWurst force-pushed the enhancement/optionally-hide-event-download branch from 03bb9ca to d46acc5 Compare March 3, 2022 15:40
@ChristophWurst ChristophWurst changed the title Allow admins to hide event download buttons Allow admins to hide event export buttons Mar 3, 2022
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@szaimen szaimen requested review from st3iny and removed request for szaimen March 3, 2022 15:58
occ config:app:set calendar hide_event_download --value=yes

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the enhancement/optionally-hide-event-download branch from d46acc5 to 6bf4d07 Compare March 3, 2022 16:13
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 3, 2022
@ChristophWurst ChristophWurst merged commit 3633e7a into main Mar 3, 2022
@ChristophWurst ChristophWurst deleted the enhancement/optionally-hide-event-download branch March 3, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request nextcloud-gmbh Tickets with importance for Nextcloud Gmbh
Projects
Development

Successfully merging this pull request may close these issues.

4 participants