Allow user to set default reminder duration for new events #3001
Conversation
Add a label to slotDuration so that the user is not left wondering what the setting refers to. I remember being puzzled myself the first time I saw it. Signed-off-by: Matteo Settenvini <[email protected]>
tchernobog
force-pushed
the
feature/default-reminder-setting
branch
2 times, most recently
from
d680b11
to
09b74a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3001 +/- ##
============================================
+ Coverage 29.18% 29.42% +0.24%
- Complexity 116 121 +5
============================================
Files 155 155
Lines 5561 5607 +46
Branches 822 825 +3
============================================
+ Hits 1623 1650 +27
- Misses 3938 3957 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tchernobog
force-pushed
the
feature/default-reminder-setting
branch
4 times, most recently
from
a145066
to
3c015df
Compare
|
Hi @ChristophWurst, do you know who could perform a review? Thanks! |
There was a problem hiding this comment.
I'm conflicted about this. It's definitely not enough to close #629 since it's only a setting to add a simple timed based DISPLAY reminder and it doesn't consider events to be allDay to suggest appropriate slots. Also it crowds even more the bottom left settings area since we don't have #2304 yet.
Still, might be handy for some people in the mean time, so 🤷
I know, and maybe I should reword the commit to avoid saying it fixes #629. But it was enough to cover my personal needs of having a default reminder set when creating events through the Web UI, which is the specific improvement I sought. I am not going after the bug bounty anyway. |
Add a setting to the app state that can be reused when creating new events to set a default alarm / reminder. Signed-off-by: Matteo Settenvini <[email protected]>
Take the value from the saved settings for the default reminder, and if it is a valid amount of seconds, add a new alarm to newly created events. Signed-off-by: Matteo Settenvini <[email protected]>
tchernobog
force-pushed
the
feature/default-reminder-setting
branch
from
3c015df
to
9e6b1c7
Compare
|
Hi @ChristophWurst, are there more changes you'd like me to perform? Thanks! |
|
@ChristophWurst, @tcitworld: any further feedback you'd like me to address? Thanks! |
|
Weekly ping :-) |
tcitworld
added
3. to review
|
Hi @ChristophWurst, any major blocker to see this merged? I wanted to contributed a few more enhancements to the calendar app, but I would first like to see how it goes with this PR. |
|
🚀 |
This PR implements a new setting in the calendar web UI to allow the user to specify a default reminder to apply to newly created events.
This is particularly helpful when you want to create a batch of events in a row.
It should provide a workable solution to issue #629, albeit it is a global setting rather than per-calendar.