Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default timeout for requests to ExApps if none is set. #277

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Set the default timeout for requests to ExApps if none is set. #277

merged 5 commits into from
Jul 10, 2024

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Apr 22, 2024 •
edited
Loading

  1. W8 for new version of ContextChat that will override timeouts and set its own where the default value(3 s) does not suit it.
  2. Add timeout in FileEventsListener.php: requestToExAppAsync
  3. Review and add timeouts for every our call to requestToExApp inside AppAPI

@bigcat88 bigcat88 changed the title added default timeout for requests to ExApps that does not set it Set the default timeout for requests to ExApps if none is set. Apr 22, 2024
@bigcat88 bigcat88 mentioned this pull request Apr 22, 2024
Closed
@andrey18106 andrey18106 marked this pull request as ready for review July 10, 2024 12:13
@andrey18106 andrey18106 self-requested a review as a code owner July 10, 2024 12:13
@andrey18106 andrey18106 enabled auto-merge (squash) July 10, 2024 12:14
@andrey18106 andrey18106 merged commit 1e71efd into main Jul 10, 2024
29 checks passed
@andrey18106 andrey18106 deleted the feat-set-default-timeout branch July 10, 2024 12:19
@bigcat88 bigcat88 mentioned this pull request Aug 8, 2024
Merged
bigcat88 added a commit that referenced this pull request Aug 8, 2024
@bigcat88
Proxy: do not set timeout for requests to ExApp (#357)
2374d55 
We forgot to change this in this PR:
#277

For Proxy requests there should be no timeout, cause they are coming
from user or external services and not from Nextcloud

Even if they will take a long time, Nextcloud instance will be not slow
down

Signed-off-by: Alexander Piskun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey18106 andrey18106 andrey18106 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigcat88 @andrey18106