Skip to content

Commit

Permalink
fix(notifications): Make the notification icons absolute URLs so they… (
Browse files Browse the repository at this point in the history
#268)

… work in clients

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
nickvergessen authored Apr 9, 2024
1 parent 1df064b commit 5acfac7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/Notifications/ExAppAdminNotifier.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function prepare(INotification $notification, string $languageCode): INot
$parameters = $notification->getSubjectParameters();

$notification->setLink($this->url->getAbsoluteURL('/index.php/settings/admin/' . Application::APP_ID));
$notification->setIcon($this->url->imagePath(Application::APP_ID, 'app-dark.svg'));
$notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg')));

if (isset($parameters['rich_subject']) && isset($parameters['rich_subject_params'])) {
$notification->setRichSubject($parameters['rich_subject'], $parameters['rich_subject_params']);
Expand Down
2 changes: 1 addition & 1 deletion lib/Notifications/ExAppNotifier.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function prepare(INotification $notification, string $languageCode): INot
if (isset($parameters['link']) && $parameters['link'] !== '') {
$notification->setLink($parameters['link']);
}
$notification->setIcon($this->url->imagePath(Application::APP_ID, 'app-dark.svg'));
$notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg')));

if (isset($parameters['rich_subject']) && isset($parameters['rich_subject_params'])) {
$notification->setRichSubject($l->t($parameters['rich_subject']), $parameters['rich_subject_params']);
Expand Down

0 comments on commit 5acfac7

Please sign in to comment.