Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revoke summarai.crt #728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

revoke summarai.crt #728

wants to merge 1 commit into from

Conversation

kyteinsky
Copy link
Contributor

@kyteinsky kyteinsky commented Sep 9, 2024

No description provided.

@kyteinsky kyteinsky changed the title Replace summarai.csr Replace summarai with summary_bot Sep 9, 2024
@nickvergessen
Copy link
Member

needs revocation as usual

@kyteinsky
Copy link
Contributor Author

Hi, sorry I don't understand what I should do, if it was meant for me? Also, the previous cert/key was not used to register any app.

@nickvergessen
Copy link
Member

No, that's for Matthieu or the sysadmin doing it :P

@camilasan
Copy link
Member

needs revocation as usual

if I run docker compose run php ./bin/certmanager certificate:revoke 728, I get The pull request need to have only a file: the certificate file.

Is that correct?

@nickvergessen
Copy link
Member

I think you need to revoke 684 which is the original PR: #684

@vitormattos
Copy link
Contributor

The revoke command was projected to revoke an appid.

At this PR have two actions: revoke and create a new cert.

To work with this tool, will be necessary two PR (the quick way, a PR revoking and a PR adding a new app). To use this PR will be necessary implement a new command, i.e. certificate:rename to consider 3 files changed by PR.

@kyteinsky
Copy link
Contributor Author

I can convert this PR to just add summary_bot if you wish to revoke #684

@camilasan
Copy link
Member

I think you need to revoke 684 which is the original PR: #684

this throws this error: This PR need to modify a csr file. The status of this PR is: added

@nickvergessen
Copy link
Member

I can convert this PR to just add summary_bot if you wish to revoke #684

Might be easier to do both things in separate PRs:

  1. Remove summarai in this PR and revoke it
  2. New PR to request summary_bot

@vitormattos
Copy link
Contributor

vitormattos commented Sep 10, 2024

This PR need to modify a csr file. The status of this PR is: added

To revoke a csr, is necessary a change of csr file. The PR 684 is adding a new csr file and this already was made. The PR 684 can't be used to revoke a certificate.

A way that solve this is:

  • change this PR to have only a file creating the summari_bot to unlock the flow to generate the crt file
  • Create a new PR only deleting (revoke) the summari.crt

@kyteinsky kyteinsky changed the title Replace summarai with summary_bot revoke summarai.crt Sep 10, 2024
@kyteinsky
Copy link
Contributor Author

summary_bot.csr is here: #729

@kyteinsky
Copy link
Contributor Author

kind pingu

@camilasan
Copy link
Member

when trying to revoke this PR with certificate:revoke 728, I am getting:
The pull request need to have only a file: the certificate file

Maybe the certificate file was not supposed to be deleted in this PR?

@camilasan
Copy link
Member

@kyteinsky could you also remove the .csr file?

@kyteinsky
Copy link
Contributor Author

And the folder too?

@camilasan
Copy link
Member

And the folder too?

just the files.

Signed-off-by: Anupam Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants