Add documents provider #3
Conversation
| android:name="org.nextcloud.providers.DocumentsStorageProvider" | ||
| android:exported="true" | ||
| android:grantUriPermissions="true" | ||
| android:permission="android.permission.MANAGE_DOCUMENTS" |
There was a problem hiding this comment.
Would this need a permission Api implementation for marshmallow and up?
There was a problem hiding this comment.
I don't think so, the reason is that this provider is exported so user are specifically calling for document provider which shouldn't require any android requirements (it queries only app local resources).
But I cannot check that on a real device because of lack of android 6 device :(
There was a problem hiding this comment.
I think I finally need to acquire one ;)
There was a problem hiding this comment.
I do have Android N Preview 3 on my phone so I can install the branch in the next days. Afk right now...
There was a problem hiding this comment.
like I commented, tested on Android N Preview, works like a charm 👍
przybylski
force-pushed
the
document_provider
branch
from
83b4f8d to
4492a87
Compare
|
@tobiasKaminsky @AndyScherzinger review pls :) |
| final FileCursor result = new FileCursor(projection); | ||
|
|
||
| final OCFile browsedDir = mCurrentStorageManager.getFileById(folderId); | ||
| for (OCFile file : mCurrentStorageManager.getFolderContent(browsedDir)) |
There was a problem hiding this comment.
please add { } to the content of the loop as this minified code is somehow confusing
|
apart from minor code formatting it LGTM |
|
I tested it on android pre6 and it was working fine on opening files. |
|
I can't review before next week, so whoever has time to do so, feel free. I am on a workshop with work so I won't be able to. Maybe I find the time to review tomorrow before the workshop. |
|
@przybylski there are a few comments on owncloud regarding this pr: owncloud/android#1368 (comment) have you checked them? |
|
One issue that came up in the beta: https://help.nextcloud.com/t/owncloud-logo-in-beta-app/1013/3 |
AndyScherzinger
force-pushed
the
document_provider
branch
from
4492a87 to
f054c7d
Compare
|
Logo has been fixed: f054c7d |
|
Will test drive the branch tomorrow. |
AndyScherzinger
force-pushed
the
document_provider
branch
from
7eed96e to
6bab4f0
Compare
|
Test has been successful on Nexus5X Android N Preview 4 |
|
👍 |
|
@przybylski the honor to push the merge button is yours 🎉 |
|
🎉 |
No description provided.