Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport mail sharing #2715

Merged
merged 4 commits into from
Jun 23, 2018
Merged

Backport mail sharing #2715

merged 4 commits into from
Jun 23, 2018

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jun 15, 2018 •
edited
Loading

Backport of #2671

@AndyScherzinger AndyScherzinger changed the base branch from master to stable-3.2.x June 15, 2018 09:20
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Jun 15, 2018 •
edited
Loading

I didn't have the chance to test the backport yet but wanted to open the PR for code review etc. as soon as possible :)

@tobiasKaminsky tobiasKaminsky mentioned this pull request Jun 15, 2018
Closed
24 tasks
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.2.1 milestone Jun 18, 2018
@AndyScherzinger
Copy link
Member Author

Backport: Tested and works

Please review @tobiasKaminsky @mario

@codecov
Copy link

codecov bot commented Jun 18, 2018 •
edited
Loading

Codecov Report

Merging #2715 into stable-3.2.x will decrease coverage by 0.01%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           stable-3.2.x   #2715      +/-   ##
===============================================
- Coverage          6.53%   6.52%   -0.02%     
===============================================
  Files               283     284       +1     
  Lines             28861   28934      +73     
  Branches           4202    4215      +13     
===============================================
+ Hits               1886    1887       +1     
- Misses            26690   26762      +72     
  Partials            285     285
Impacted Files Coverage Δ
...ndroid/operations/UpdateShareViaLinkOperation.java 0% <ø> (ø) ⬆️
...ain/java/com/owncloud/android/db/ProviderMeta.java 88% <ø> (ø) ⬆️
...fragment/util/FileDetailSharingFragmentHelper.java 0% <ø> (ø) ⬆️
...ud/android/ui/fragment/util/SharingMenuHelper.java 0% <0%> (ø)
...android/ui/dialog/SharePasswordDialogFragment.java 0% <0%> (ø) ⬆️
...m/owncloud/android/services/OperationsService.java 0% <0%> (ø) ⬆️
...wncloud/android/providers/FileContentProvider.java 17.29% <0%> (-0.24%) ⬇️
...m/owncloud/android/ui/adapter/UserListAdapter.java 0% <0%> (ø) ⬆️
...loud/android/datamodel/FileDataStorageManager.java 10.57% <0%> (-0.04%) ⬇️
...id/operations/UpdateSharePermissionsOperation.java 0% <0%> (ø) ⬆️
... and 4 more

@mario
Copy link
Contributor

mario commented Jun 21, 2018 •
edited by AndyScherzinger
Loading

👍

Approved with PullApprove

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jun 22, 2018 •
edited by AndyScherzinger
Loading

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit 6ccd05a into stable-3.2.x Jun 23, 2018
@AndyScherzinger AndyScherzinger deleted the backportMailSharing branch June 23, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud App 3.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyScherzinger @mario @tobiasKaminsky