-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only Download Necessary Files #13683
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Can you explain reason behind filtering media files? This worker is also used when exporting files (FilesExportWork.kt), so this would then not work if you want to export a pdf file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
FilesExportWork only triggers the FileDownloadWorker when a file hasn’t been downloaded, so the filter introduced in this PR won’t be applied. Here’s a demo of FilesExportWork with already downloaded files. exp.mp4You can check the PR description for more details on the purpose of this PR. |
I'm eagerly waiting for this PR. I have a Google Pixel 8, and files are constantly resyncing every 15 minutes. It drains the battery significantly and uses bandwidth unnecessarily. Do you guys know when it will be merged? Thanks. |
Problem
Downloaded files are re-downloading, and notifications appear for files that have already been downloaded. The sync should only trigger downloads for new or editable files, as media files cannot be changed.
The two-way sync triggers the FileDownloadWorker every 15 minutes. If a folder contains multiple files, even if all files are already downloaded, the worker will still show notifications for each file and attempt to re-download them again.
Note: Images can be edited, but any edited image will create a copy rather than modifying the original file. Thus, no need to download original image.
Changes
Demo
test.mp4