Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - Check Filename in UriUploader #13606

Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 23, 2024

  • Tests written, or not not needed

How to Test?

  1. Enable Windows file compatibility capability
  2. Try to share file (e.g. /abc/11.jpg) from other apps
  3. An error message should appear, but actually file path and filename is valid.

Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13606.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit d4ea700 into master Sep 24, 2024
22 checks passed
@alperozturk96 alperozturk96 deleted the bugfix/check-file-name-not-path-in-uri-uploader branch September 24, 2024 07:04
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants