Switching to dav4jvm

[tobiasKaminsky]

Heavily under construction 🚧
If you have any feedback, please comment :)

Signed-off-by: tobiasKaminsky [email protected]

[tobiasKaminsky]

@AlvaroBrey if you have a bit of time, any feedback would be great 💙

[AlvaroBrey]

• Unused submodule?

[AlvaroBrey]

As we're working on a static singleton (PropertyRegistry.INSTANCE), I guess it would be better to initialize this list in a static block in order to avoid having to call it explicitly on clients.

[AlvaroBrey]

I don't think it's a good idea to create a new OkHttpClient for every request... the NextcloudClient passed to run should already be authenticated IMO. Not sure about the redirects or why they are disabled.

[AlvaroBrey]

This does not seem necessary, as the search method is never called (only used to get the query string)

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

[codecov]

Codecov Report

Attention: Patch coverage is 66.07362% with 553 lines in your changes missing coverage. Please review.

Project coverage is 51.19%. Comparing base (bf33890) to head (4f7f56d).

Files	Patch %	Lines
...oid/lib/common/operations/RemoteOperationResult.kt	52.03%	94 Missing and 59 partials ⚠️
...ud/android/lib/resources/files/model/RemoteFile.kt	25.71%	23 Missing and 3 partials ⚠️
...owncloud/android/lib/common/network/WebdavEntry.kt	62.50%	20 Missing and 4 partials ⚠️
...ncloud/android/lib/common/utils/WebDavFileUtils.kt	72.22%	9 Missing and 11 partials ⚠️
...c/main/java/com/nextcloud/operations/MoveMethod.kt	0.00%	17 Missing ⚠️
...ud/android/lib/resources/files/webdav/NCSharees.kt	70.21%	2 Missing and 12 partials ⚠️
...owncloud/android/lib/common/network/WebdavUtils.kt	92.44%	6 Missing and 7 partials ⚠️
...cloud/android/lib/resources/files/webdav/NCTags.kt	70.00%	7 Missing and 5 partials ⚠️
...b/resources/files/webdav/NCTrashbinDeletionTime.kt	23.07%	10 Missing ⚠️
...d/lib/resources/files/webdav/NCTrashbinFilename.kt	23.07%	10 Missing ⚠️
... and 59 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #881      +/-   ##
============================================
+ Coverage     49.16%   51.19%   +2.03%     
- Complexity     1000     1147     +147     
============================================
  Files           208      256      +48     
  Lines          7819     8372     +553     
  Branches       1017     1107      +90     
============================================
+ Hits           3844     4286     +442     
- Misses         3421     3464      +43     
- Partials        554      622      +68     

Files	Coverage Δ
...ces/groupfolders/GetGroupfoldersRemoteOperation.kt	61.29% <100.00%> (ø)
...b/resources/profile/GetHoverCardRemoteOperation.kt	57.14% <100.00%> (ø)
...ry/src/main/java/com/nextcloud/common/DavMethod.kt	100.00% <100.00%> (ø)
.../main/java/com/nextcloud/common/NextcloudClient.kt	50.45% <100.00%> (+3.92%)	⬆️
...main/java/com/nextcloud/common/OkHttpMethodBase.kt	64.81% <ø> (-1.26%)	⬇️
.../java/com/nextcloud/common/UserAgentInterceptor.kt	100.00% <100.00%> (ø)
...n/java/com/nextcloud/extensions/ArrayExtensions.kt	100.00% <100.00%> (ø)
...in/java/com/nextcloud/operations/PropFindResult.kt	100.00% <100.00%> (ø)
...rc/main/java/com/nextcloud/operations/PutMethod.kt	83.33% <100.00%> (+11.90%)	⬆️
...d/android/lib/common/network/ExtendedProperties.kt	100.00% <100.00%> (ø)
... and 83 more

... and 5 files with indirect coverage changes

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	31
Dodgy code	26	27
Internationalization	6	4
Malicious code vulnerability	49	44
Multithreaded correctness	3	3
Performance	8	8
Security	0	2
Total	161	154

[nextcloud-android-bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3424-IT-stable-15-01/debug/

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3424-IT-master-15-05/debug/