Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run() always work, even with old ocClient #1471

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobiasKaminsky
Copy link
Member

This reduces risk of breaking our client.

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2626
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161164

SpotBugs increased!

Copy link
Contributor

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my tests this has worked perfectly so far.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.16%. Comparing base (4a78745) to head (a83ce15).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1471      +/-   ##
============================================
- Coverage     49.25%   49.16%   -0.09%     
+ Complexity     1003     1002       -1     
============================================
  Files           208      208              
  Lines          7823     7826       +3     
  Branches       1015     1016       +1     
============================================
- Hits           3853     3848       -5     
- Misses         3418     3426       +8     
  Partials        552      552              
Files Coverage Δ
...android/lib/common/operations/RemoteOperation.java 11.02% <0.00%> (-0.09%) ⬇️
...om/owncloud/android/lib/common/OwnCloudClient.java 43.08% <12.50%> (-1.36%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: tobiasKaminsky <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2626
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161164

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants