Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OwncloudClient - Comments #1295

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Deprecate OwncloudClient - Comments #1295

merged 1 commit into from
Jun 12, 2024

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Jan 10, 2024

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

  • changes related to comments

@ZetaTom ZetaTom self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.27%. Comparing base (cda1b08) to head (3b672c1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1295      +/-   ##
============================================
- Coverage     49.28%   49.27%   -0.02%     
  Complexity     1002     1002              
============================================
  Files           208      208              
  Lines          7830     7824       -6     
  Branches       1015     1016       +1     
============================================
- Hits           3859     3855       -4     
+ Misses         3417     3416       -1     
+ Partials        554      553       -1     
Files Coverage Δ
...resources/comments/CommentFileRemoteOperation.java 75.00% <80.00%> (-5.77%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky tobiasKaminsky merged commit 8471187 into master Jun 12, 2024
19 of 20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the depocc/comments branch June 12, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants