Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker socket proxy to manual install #5377

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sheikhmishar
Copy link
Contributor

I've added and tested docker-socket-proxy for the manual installation of AIO. This will be useful for using AppAPI and ExApp for manual mode users

@szaimen
Copy link
Collaborator

szaimen commented Oct 4, 2024

Hi @sheikhmishar, thanks a lot for your contribution!

We could think about adding the docker-socket-proxy container but then the question remains why you are using the manual install if a container having access to the docker socket that also creates additonal containers is apparently not a problem for you?

Regarding adding community containers, I fear this is out of scope since they rely on some custom config which is only possible to be used in a sensible way when using the mastercontainer like e.g. aio_variables or nextcloud_exec_commands. We also might add more later on.

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Oct 4, 2024
@szaimen szaimen modified the milestones: next, v9.7.0 Oct 4, 2024
@szaimen szaimen marked this pull request as draft October 22, 2024 09:43
@szaimen szaimen modified the milestones: v9.8.0, next Oct 30, 2024
@A4alli

This comment was marked as off-topic.

@szaimen szaimen removed this from the next milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants