Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change dockerfile links, add tzdata to fulltext, migrate healthchecks to nc #1619

Merged
merged 1 commit into from
Dec 29, 2022
Merged

change dockerfile links, add tzdata to fulltext, migrate healthchecks to nc #1619

merged 1 commit into from
Dec 29, 2022

Conversation

Zoey2936
Copy link
Collaborator

Signed-off-by: Zoey [email protected]
for #1617

@Zoey2936
Copy link
Collaborator Author

@szaimen as this seems to not help #1617 I would say that I remove the /dev/null part and migrate the other healthchecks to netcat

@szaimen szaimen added this to the next milestone Dec 28, 2022
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Dec 28, 2022
@szaimen
Copy link
Collaborator

szaimen commented Dec 28, 2022 •
edited
Loading

@szaimen as this seems to not help #1617 I would say that I remove the /dev/null part and migrate the other healthchecks to netcat

All right, that sounds good to me 👍
Thanks a lot! :)

@Zoey2936 Zoey2936 changed the title make healthchecks silent change dockerfile links, add tzdata to fulltext, migrate healthchecks to nc Dec 28, 2022
@Zoey2936
Copy link
Collaborator Author

@szaimen I think you can now have a look

@Zoey2936 Zoey2936 mentioned this pull request Dec 28, 2022
Merged
2 tasks
@szaimen szaimen mentioned this pull request Dec 29, 2022
Closed
33 tasks
szaimen
szaimen approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@szaimen szaimen merged commit c21087d into main Dec 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the change-healthchecks branch December 29, 2022 15:40
@szaimen
Copy link
Collaborator

szaimen commented Jan 5, 2023

This is now released with v4.1.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v.4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Zoey2936 @szaimen