-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the usermountcache to get all users who have access to a file #190
Conversation
6ac047b
to
dc9c143
Compare
Tested it and sharing still works. However when using external storage, the activity is still only generated for the actor and not all other users of the external storage. Isn't that what you were trying to fix? @icewind1991 |
Works for me, created an external storage, gave 2 users access. If user A uploads a file, it shows in user B's activity |
Files uploaded in a groupfolder are not listed in the activities. |
dc9c143
to
d3f84e7
Compare
rebased and re-tested, works for me with both groupfolders and external storage. Note that after adding the groupfolder/external storage all involved users will need to load the files app/dav once to update the cached list of mounts the user has access to |
Okay, so I tested it a bit, moving/renaming is not working, but this can be fixed by moving your new code to the But I'm not sure the "until they accessed webdav" is okay. The problem is that it also works the other way around. I shared a the external storage with user2, logged in+out as user2, unshared the external storage from user2 and created activity. Although user2 has no access anymore, all activity is generated and visible until they relogin/use webdav. |
How does this get progressed? |
Looks like we need to move this to 14. |
the missing activity in group folders is quite an issue for clients; is this a patch we can apply to an install of 12 or 13? |
Not having Activity for group folders gave a lot of extra work for us to track down which user had written 0KB into some files so we could restore them from that users revision. |
Is there anything we can do to move this forward? |
@nickvergessen @icewind1991 What is missing here? |
A solution to the problem so it works in both cases |
@nickvergessen Moved to 15. |
Are there still plans to integrate activity in groupfolders in the activity stream of users with access to that folder? |
please fix this :D it would help us so tremendous. |
Hi folks, Greetz and a happy new Year from here :) |
I'm locking the conversation here. We know this is an issue, it will get fixed at some point. |
9bdda0a
to
b6a23c3
Compare
/backport to stable18 |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
165a6fb
to
766eab3
Compare
So lets get this in? @icewind1991 @rullzer |
Quick question: Does the nextcloud client suffice as a login for this? Otherwise I can't wait for this. Will implement it manually by the weekend if it's not merged by then. You will have made so many people happy! |
👍 |
/backport to stable18 |
Is backporting not possible? Why does backport-bot not create the PR? |
I'm pretty sure backporting this code works, while the used APIs might not be available. So don't merge a potential backport immediately |
The backport was created in #457 btw, seems like the linking failed. |
Fixes activity when multiple users have access to the same files not trough sharing (but instead external storage, group folders, etc)
Fix #264