Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the usermountcache to get all users who have access to a file #190

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Aug 22, 2017

Fixes activity when multiple users have access to the same files not trough sharing (but instead external storage, group folders, etc)

Fix #264

@nickvergessen
Copy link
Member

Tested it and sharing still works.

However when using external storage, the activity is still only generated for the actor and not all other users of the external storage. Isn't that what you were trying to fix? @icewind1991

@icewind1991
Copy link
Member Author

Works for me, created an external storage, gave 2 users access.

If user A uploads a file, it shows in user B's activity

@mc9625
Copy link

mc9625 commented Nov 28, 2017

Files uploaded in a groupfolder are not listed in the activities.

@icewind1991 icewind1991 force-pushed the use-usermountcache-for-accesslist branch from dc9c143 to d3f84e7 Compare December 12, 2017 12:38
@icewind1991
Copy link
Member Author

rebased and re-tested, works for me with both groupfolders and external storage.

Note that after adding the groupfolder/external storage all involved users will need to load the files app/dav once to update the cached list of mounts the user has access to

@nickvergessen
Copy link
Member

Okay, so I tested it a bit, moving/renaming is not working, but this can be fixed by moving your new code to the getUserPathsFromPath method. Also the paths now include /<userid>/files but that is also easily fixable.

But I'm not sure the "until they accessed webdav" is okay. The problem is that it also works the other way around. I shared a the external storage with user2, logged in+out as user2, unshared the external storage from user2 and created activity. Although user2 has no access anymore, all activity is generated and visible until they relogin/use webdav.

@putt1ck
Copy link

putt1ck commented Jan 11, 2018

How does this get progressed?

@MorrisJobke
Copy link
Member

Looks like we need to move this to 14.

@putt1ck
Copy link

putt1ck commented Jan 18, 2018

the missing activity in group folders is quite an issue for clients; is this a patch we can apply to an install of 12 or 13?

@pascalBokBok
Copy link

Not having Activity for group folders gave a lot of extra work for us to track down which user had written 0KB into some files so we could restore them from that users revision.

@putt1ck
Copy link

putt1ck commented Jun 22, 2018

Is there anything we can do to move this forward?

@MorrisJobke
Copy link
Member

@nickvergessen @icewind1991 What is missing here?

@nickvergessen
Copy link
Member

A solution to the problem so it works in both cases

@MorrisJobke MorrisJobke mentioned this pull request Aug 30, 2018
6 tasks
@MorrisJobke
Copy link
Member

@nickvergessen Moved to 15.

@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
29 tasks
@nickvergessen nickvergessen removed this from the Nextcloud 15 milestone Nov 6, 2018
@noresistence
Copy link

Are there still plans to integrate activity in groupfolders in the activity stream of users with access to that folder?

@hriekehof
Copy link

please fix this :D it would help us so tremendous.

@ghosttable
Copy link

Hi folks,
i know you are out of ideas but this needs to get fixed.
Notification for new files inside a company Nextcloud configured with Group folders is very important for us. And i think, if you follow the Threads not only for us.

Greetz and a happy new Year from here :)

@nextcloud nextcloud locked and limited conversation to collaborators Jan 9, 2020
@nickvergessen
Copy link
Member

I'm locking the conversation here. We know this is an issue, it will get fixed at some point.

@nickvergessen nickvergessen force-pushed the use-usermountcache-for-accesslist branch 2 times, most recently from 9bdda0a to b6a23c3 Compare March 10, 2020 09:50
@nickvergessen
Copy link
Member

Added a config flag together with the following documentation for now:

Bildschirmfoto von 2020-03-10 12-27-24

@nickvergessen
Copy link
Member

/backport to stable18

@nickvergessen nickvergessen force-pushed the use-usermountcache-for-accesslist branch from 165a6fb to 766eab3 Compare March 18, 2020 11:26
@nickvergessen
Copy link
Member

So lets get this in? @icewind1991 @rullzer

@RuudschMaHinda
Copy link
Member

Quick question: Does the nextcloud client suffice as a login for this?

Otherwise I can't wait for this. Will implement it manually by the weekend if it's not merged by then. You will have made so many people happy!

@icewind1991
Copy link
Member Author

👍

@nickvergessen nickvergessen merged commit 701ff57 into master Apr 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the use-usermountcache-for-accesslist branch April 1, 2020 15:22
@wiswedel
Copy link

wiswedel commented May 5, 2020

/backport to stable18

@wiswedel
Copy link

wiswedel commented May 5, 2020

Is backporting not possible? Why does backport-bot not create the PR?

@nickvergessen
Copy link
Member

I'm pretty sure backporting this code works, while the used APIs might not be available. So don't merge a potential backport immediately

@nickvergessen
Copy link
Member

The backport was created in #457 btw, seems like the linking failed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not working with group folders