-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable30] fix: do not send daily digest email to user who is disabled #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not used Signed-off-by: yemkareems <[email protected]>
Signed-off-by: yemkareems <[email protected]> [skip ci]
backportbot
bot
requested review from
artonge,
miaulalala,
provokateurin and
yemkareems
October 28, 2024 15:02
artonge
approved these changes
Oct 28, 2024
Signed-off-by: yemkareems <[email protected]>
Activity Run #2064
Run Properties:
|
Project |
Activity
|
Branch Review |
backport/1803/stable30
|
Run status |
Failed #2064
|
Run duration | 03m 19s |
Commit |
3002250757: [stable30] fix: do not send daily digest email to user who is disabled
|
Committer | backportbot[bot] |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
2
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
8
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E
Test | Artifacts | |
---|---|---|
Check activity listing in the sidebar > Has share activity |
Test Replay
Screenshots
|
|
Check activity listing in the sidebar > Has tag activity |
Test Replay
Screenshots
|
cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E
Test | Artifacts | |
---|---|---|
Check activity listing in the sidebar > Has comment activity |
Test Replay
Screenshots
|
yemkareems
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1803
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.