-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidebar): Add frontend API that allows to register custom entries #1416
Conversation
bd207f5
to
490d8c8
Compare
The diff looks awful but in reality e.g. Activity.vue was just renamed to GenericActivity.vue and Activity.vue is now a wrapper... |
490d8c8
to
4912c3a
Compare
This is intended for the comments app to register the "write comment" action. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
4912c3a
to
3f752e3
Compare
/compile amend/ |
A screen cast of how it looks when comments use it can be found here: |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
3f752e3
to
0ab1a4f
Compare
/compile amend/ |
Signed-off-by: nextcloud-command <[email protected]>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
This adds a front end API that allows to register plugins on the Activity tab:
Why showing custom elements instead of the activity? Activities will be cleaned up while e.g. comments do not. So this allows e.g. comments to be shown within the activity sidebar tab.