groupfolder activities on move/rename #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
enh/noid/gf-activity-on-move
branch
from
64535ec
to
bbffa21
Compare
ArtificialOwl
force-pushed
the
enh/noid/gf-activity-on-move
branch
from
bbffa21
to
232757b
Compare
|
/rebase |
Signed-off-by: Maxence Lange <[email protected]>
nextcloud-command
force-pushed
the
enh/noid/gf-activity-on-move
branch
from
232757b
to
853772f
Compare
artonge
reviewed
May 15, 2023
| // file can be shared using GroupFolders, including ACL check | ||
| if ($this->config->getSystemValueBool('activity_use_cached_mountpoints', false)) { | ||
| $this->userMountCache->clear(); // clear cache for new data | ||
| $affectedUsers = array_merge($affectedUsers, $this->getAffectedUsersFromCachedMounts($fileId)); |
There was a problem hiding this comment.
Why merge? Isn't getAffectedUsersFromCachedMounts supposed to return an updated list?
There was a problem hiding this comment.
Same question for other changes.
There was a problem hiding this comment.
the list is cached by UserMountCache. because we are moving files, we only get old data from pre-move; clearing the cache allows to get fresh data post-move
There was a problem hiding this comment.
Ah, I get it, the list is different pre- and post-move as the impacted user are of course different. Thanks :)
icewind1991
approved these changes
May 22, 2023
artonge
approved these changes
May 22, 2023
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
This was referenced Jun 6, 2023
|
/backport to stable23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieve the list of affectedUsers related to groupfolders, including ACL checks.
On file moving, it does the handling the same way a file is moved from a shared folder to another.
Meaning that if a user gain or loose read rights during the moving process the file is said as new or deleted
This is from the point of view of a user with no ACL limitation:
And this is from the point of view of a user that have not access to the folder a file is moved to/from:
