Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: AGP 8 and Java 17 #629

Merged
merged 4 commits into from
Jan 19, 2024
Merged

chore: AGP 8 and Java 17 #629

merged 4 commits into from
Jan 19, 2024

Conversation

stefan-niedermann
Copy link
Member

Successor of #625

@AndyScherzinger
Copy link
Member

Talk Android runs on Java17 already -> https://github.com/nextcloud/talk-android/blob/master/.drone.yml

But apart from that @tobiasKaminsky knows the drone containers best

Signed-off-by: Stefan Niedermann <[email protected]>
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jan 19, 2024
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @stefan-niedermann - CI is green now 👍

@AndyScherzinger AndyScherzinger marked this pull request as ready for review January 19, 2024 14:28
@AndyScherzinger AndyScherzinger added 4. to release Save to merge and removed 3. to review Waiting for reviews labels Jan 19, 2024
@AndyScherzinger AndyScherzinger merged commit 302ed1b into master Jan 19, 2024
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the agp-8 branch January 19, 2024 15:23
@AndyScherzinger
Copy link
Member

jitpack run has also been successful 👍

...merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Save to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants